[smart_switch][dhcp_server] Fix query dhcp lease get unknown in smart…

… switch by Cli (sonic-net#20642)

Why I did it
In smart switch, there is an issue that Cli query dhcp lease got unknow interface due to dpu fdb hasn't present in STATE_DB FDB_TABLE. Issue: sonic-net#20155

How I did it
Query bridge fdb if there is no fdb record in STATE_DB

How to verify it
UT passed

dockers/docker-dhcp-server/cli-plugin-tests/mock_state_db.json

@@ -14,6 +14,11 @@
         "lease_end": "1677641481",
         "ip": "192.168.0.3"
     },
+    "DHCP_SERVER_IPV4_LEASE|bridge-midplane|10:70:fd:b6:13:03": {
+        "lease_start": "1677640581",
+        "lease_end": "1677641481",
+        "ip": "192.168.0.4"
+    },
     "DHCP_SERVER_IPV4_SERVER_IP|eth0": {
         "ip": "240.127.1.2"
     },

dockers/docker-dhcp-server/cli-plugin-tests/pytest.ini

@@ -1,3 +1,2 @@
 [pytest]
-addopts = --cov-config=.coveragerc --cov --cov-report html --cov-report term --cov-report xml --junitxml=test-results.xml -vv
-
+addopts = --cov=/sonic/dockers/docker-dhcp-server/cli --cov-config=.coveragerc --cov-report html --cov-report term --cov-report term-missing --cov-report xml --junitxml=test-results.xml -vv

dockers/docker-dhcp-server/cli-plugin-tests/test_show_dhcp_server.py

@@ -9,39 +9,41 @@
 sys.path.append('../cli/show/plugins/')
 import show_dhcp_server
 
+BRIDGE_FDB_MAC = {
+    "10:70:fd:b6:13:03": "dpu0"
+}
 
-class TestShowDHCPServer(object):
+
+class TestShowDHCPServerLease(object):
     def test_plugin_registration(self):
         cli = mock.MagicMock()
         show_dhcp_server.register(cli)
 
-    @pytest.mark.parametrize("state", ["disabled", "enabled"])
-    def test_show_dhcp_server_feature_state_checking(self, mock_db, state):
-        runner = CliRunner()
-        db = clicommon.Db()
-        db.db = mock_db
-        mock_db.set("CONFIG_DB", "FEATURE|dhcp_server", "state", state)
-        result = runner.invoke(show_dhcp_server.dhcp_server, obj=db)
-        if state == "disabled":
-            assert result.exit_code == 2, "exit code: {}, Exception: {}, Traceback: {}".format(result.exit_code, result.exception, result.exc_info)
-            assert "Feature dhcp_server is not enabled" in result.output
-        elif state == "enabled":
-            assert result.exit_code == 0, "exit code: {}, Exception: {}, Traceback: {}".format(result.exit_code, result.exception, result.exc_info)
-            assert "Usage: dhcp_server [OPTIONS] COMMAND [ARGS]" in result.output
-        else:
-            assert False
+    @pytest.fixture(scope="class", autouse=True)
+    def mock_run_cmd_fixture(self):
+        def mock_run_command(cmd, return_cmd=False, shell=False):
+            splits = cmd.split("sudo bridge fdb show | grep ")
+            if len(splits) == 2 and splits[1] in BRIDGE_FDB_MAC:
+                return ("{} dev {} master bridge-midplane".format(splits[1], BRIDGE_FDB_MAC[splits[1]]), 0)
+            else:
+                return ("", 0)
+
+        with mock.patch("utilities_common.cli.run_command", side_effect=mock_run_command):
+            yield
 
     def test_show_dhcp_server_ipv4_lease_without_dhcpintf(self, mock_db):
         expected_stdout = """\
-+---------------------+-------------------+-------------+---------------------+---------------------+
-| Interface           | MAC Address       | IP          | Lease Start         | Lease End           |
-+=====================+===================+=============+=====================+=====================+
-| Vlan1000|Ethernet10 | 10:70:fd:b6:13:00 | 192.168.0.1 | 2023-03-01 03:16:21 | 2023-03-01 03:31:21 |
-+---------------------+-------------------+-------------+---------------------+---------------------+
-| Vlan1000|Ethernet11 | 10:70:fd:b6:13:01 | 192.168.0.2 | 2023-03-01 03:16:21 | 2023-03-01 03:31:21 |
-+---------------------+-------------------+-------------+---------------------+---------------------+
-| Vlan1001|<Unknown>  | 10:70:fd:b6:13:02 | 192.168.0.3 | 2023-03-01 03:16:21 | 2023-03-01 03:31:21 |
-+---------------------+-------------------+-------------+---------------------+---------------------+
++----------------------+-------------------+-------------+---------------------+---------------------+
+| Interface            | MAC Address       | IP          | Lease Start         | Lease End           |
++======================+===================+=============+=====================+=====================+
+| Vlan1000|Ethernet10  | 10:70:fd:b6:13:00 | 192.168.0.1 | 2023-03-01 03:16:21 | 2023-03-01 03:31:21 |
++----------------------+-------------------+-------------+---------------------+---------------------+
+| Vlan1000|Ethernet11  | 10:70:fd:b6:13:01 | 192.168.0.2 | 2023-03-01 03:16:21 | 2023-03-01 03:31:21 |
++----------------------+-------------------+-------------+---------------------+---------------------+
+| Vlan1001|<Unknown>   | 10:70:fd:b6:13:02 | 192.168.0.3 | 2023-03-01 03:16:21 | 2023-03-01 03:31:21 |
++----------------------+-------------------+-------------+---------------------+---------------------+
+| bridge-midplane|dpu0 | 10:70:fd:b6:13:03 | 192.168.0.4 | 2023-03-01 03:16:21 | 2023-03-01 03:31:21 |
++----------------------+-------------------+-------------+---------------------+---------------------+
 """
         runner = CliRunner()
         db = clicommon.Db()
@@ -82,6 +84,28 @@ def test_show_dhcp_server_ipv4_lease_client_not_in_fdb(self, mock_db):
         assert result.exit_code == 0, "exit code: {}, Exception: {}, Traceback: {}".format(result.exit_code, result.exception, result.exc_info)
         assert result.stdout == expected_stdout
 
+
+class TestShowDHCPServer(object):
+    def test_plugin_registration(self):
+        cli = mock.MagicMock()
+        show_dhcp_server.register(cli)
+
+    @pytest.mark.parametrize("state", ["disabled", "enabled"])
+    def test_show_dhcp_server_feature_state_checking(self, mock_db, state):
+        runner = CliRunner()
+        db = clicommon.Db()
+        db.db = mock_db
+        mock_db.set("CONFIG_DB", "FEATURE|dhcp_server", "state", state)
+        result = runner.invoke(show_dhcp_server.dhcp_server, obj=db)
+        if state == "disabled":
+            assert result.exit_code == 2, "exit code: {}, Exception: {}, Traceback: {}".format(result.exit_code, result.exception, result.exc_info)
+            assert "Feature dhcp_server is not enabled" in result.output
+        elif state == "enabled":
+            assert result.exit_code == 0, "exit code: {}, Exception: {}, Traceback: {}".format(result.exit_code, result.exception, result.exc_info)
+            assert "Usage: dhcp_server [OPTIONS] COMMAND [ARGS]" in result.output
+        else:
+            assert False
+
     def test_show_dhcp_server_ipv4_range_without_name(self, mock_db):
         expected_stdout = """\
 +---------+------------+------------+------------------------+

dockers/docker-dhcp-server/cli/show/plugins/show_dhcp_server.py

@@ -1,12 +1,12 @@
 import click
+import re
 from tabulate import tabulate
 import utilities_common.cli as clicommon
 
 
 import ipaddress
 from datetime import datetime
 import fnmatch
-import re
 
 
 def ts_to_str(ts):
@@ -43,6 +43,12 @@ def lease(db, dhcp_interface):
         entry = dbconn.get_all("STATE_DB", key)
         interface, mac = key.split("|")[1:]
         port = dbconn.get("STATE_DB", "FDB_TABLE|" + interface + ":" + mac, "port")
+        if not port:
+            # Smart switch sample: aa:bb:cc:dd:ee:ff dev dpu0 master bridge-midplane
+            (out, _) = clicommon.run_command("sudo bridge fdb show | grep {}".format(mac), return_cmd=True, shell=True)
+            match = re.match(r'([0-9A-Fa-f]{2}:){5}[0-9A-Fa-f]{2} dev (.*) master (.*)', out)
+            if match and match.group(3).strip() == interface:
+                port = match.group(2).strip()
         if not port:
             port = "<Unknown>"
         table.append([interface + "|" + port, mac, entry["ip"], ts_to_str(entry["lease_start"]), ts_to_str(entry["lease_end"])])