Skip to content

Fix connection closing issue in conncection pool #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix connection closing issue in conncection pool #113

wants to merge 1 commit into from

Conversation

Cycloctane
Copy link
Contributor

Fixes #112

  • Replace conn.close() with conn.ensure_closed() in Pool.fill_free_pool() and Pool.wait_closed().
  • Update docstring of Connection.ensure_closed

@long2ice long2ice force-pushed the dev branch 3 times, most recently from a036841 to 6c16f3b Compare December 12, 2024 14:07
@Cycloctane
fix improper handling of connection closing in pool
e6da2fa 
-  use `conn.ensure_closed()` in `fill_free_pool()` and `wait_closed()`
- fix docstring of `Connection.ensure_closed`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection pool can not close its connections properly
1 participant
@Cycloctane