Add WebView #2
Merged
Add WebView #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
huacnlee
commented
Jun 27, 2024
•
huacnlee
commented
- gpui: Add WebView support huacnlee/zed#6
- gpui: Export raw_window_handle for wry to render WebView, and with a WebView example zed-industries/zed#13730
huacnlee
force-pushed
the
add-webview
branch
2 times, most recently
from
fcddc36 to
f33c1ee
Compare
This was referenced Jul 9, 2024
huacnlee
added a commit
that referenced
this pull request
Jul 11, 2024
## Goal Change to let Popup elements open into a window, to make sure the Popup windows, panels, menus render top than the WebView. Then we can embed wry or other webview into GPUI. https://github.com/huacnlee/gpui-component/assets/5518/ce005456-088f-4298-bf5d-2642cf96faff ---- This is also like other software, they are also used in child window to render the menus, popups. - #2 - zed-industries/zed#13730 ## Todos - [x] Multiple display window position. - [x] Windows transparent background. (No transparent, just render a correct window border) - [x] Disable window resize on Windows. - [ ] Handle Menu action. - [x] Provided `popover` or `window` two mode to uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.