Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): Move the service construction to s3 service #164

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mantissahz
Copy link
Contributor

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#5840

What this PR does / why we need it:

Refactor: Move the backup store s3 service construction to the service constructor.

Special notes for your reviewer:

Additional documentation or context

Full regression test: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6585/

innobead
innobead previously approved these changes Jun 3, 2024
@innobead
Copy link
Member

innobead commented Jun 3, 2024

@mantissahz Please resolve the conflict, and then we can merge this PR.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.24%. Comparing base (3bce6e6) to head (0ee398c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   18.24%   18.24%           
=======================================
  Files           3        3           
  Lines         433      433           
=======================================
  Hits           79       79           
  Misses        347      347           
  Partials        7        7           
Flag Coverage Δ
unittests 18.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@innobead innobead merged commit 5ec9a30 into longhorn:master Jun 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants