feat(backupbackingimage): add parameters to backup backing image create proto #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
=========================================
- Coverage 7.87% 7.86% -0.02%
=========================================
Files 23 23
Lines 2006 2010 +4
=========================================
Hits 158 158
- Misses 1822 1826 +4
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
derekbit
previously approved these changes
Jul 19, 2024
derekbit
reviewed
Aug 20, 2024
ChanYiLin
force-pushed
the
LH8884_store_secret_in_backupbackingimage
branch
3 times, most recently
from
b4d7650
to
d450e09
Compare
…te proto ref: longhorn/longhorn 8884 Signed-off-by: Jack Lin <[email protected]>
ChanYiLin
force-pushed
the
LH8884_store_secret_in_backupbackingimage
branch
from
d450e09
to
ba5bad4
Compare
updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#8884
define
parameters: in thebackup configfor performing the backupsecret: in thebackupBackingImage configwhich will be stored in the .cfg filesecretNamespace: in thebackupBackingImage configwhich will be stored in the .cfg fileupdate
InspectBackupBackingImage()to fill in thesecretandsecretNamespacewhen getting the values back from the backupstore config