Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log level and flag operations #76

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7939

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, others LGTM.

What's difference among level, print-leve and flag?

pkg/spdk/client/basic.go Show resolved Hide resolved
@derekbit
Copy link
Member Author

Just one comment, others LGTM.

What's difference among level, print-leve and flag?

print-level is for stderr/stdout, and level is for syslog.
https://github.com/spdk/spdk/blob/master/lib/log/log.c#L158-L173

Longhorn 7939

Signed-off-by: Derek Su <[email protected]>
pkg/spdk/client/basic.go Outdated Show resolved Hide resolved
pkg/spdk/client/basic.go Outdated Show resolved Hide resolved
@innobead innobead merged commit a6d23f9 into longhorn:main Feb 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants