Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency sqlite3 to ^5.0.2 #7009

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sqlite3 ^5.0.0 -> ^5.0.2 age adoption passing confidence

Release Notes

mapbox/node-sqlite3

v5.0.2

Compare Source

  • build: rebuild binaries before publishing #​1426

v5.0.1

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from hacksparrow as a code owner January 10, 2021 03:13
@bajtos
Copy link
Member

bajtos commented Jan 12, 2021

continuous-integration/appveyor/pr — AppVeyor build failed

Looks like the new sqlite3 version does not compile on Windows.

lerna ERR! npm ci exited 1 in '@loopback/typeorm'
lerna ERR! npm ci stdout:
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  nothing.c
  win_delay_load_hook.cc
  nothing.vcxproj -> C:\projects\loopback-next\extensions\typeorm\node_modules\sqlite3\build\Release\\nothing.lib
  unpack_sqlite_dep
  sqlite3.c
  win_delay_load_hook.cc
  sqlite3.vcxproj -> C:\projects\loopback-next\extensions\typeorm\node_modules\sqlite3\build\Release\\sqlite3.lib
  backup.cc
  database.cc
..\src\database.cc(35): error C2248: 'Napi::Env::DefaultFini': cannot access private member declared in class 'Napi::Env' [C:\projects\loopback-next\extensions\typeorm\node_modules\sqlite3\build\node_sqlite3.vcxproj]
  c:\projects\loopback-next\extensions\typeorm\node_modules\node-addon-api\napi-inl.h(475): note: see declaration of 'Napi::Env::DefaultFini'
  C:\projects\loopback-next\extensions\typeorm\node_modules\node-addon-api\napi.h(168): note: see declaration of 'Napi::Env'
  node_sqlite3.cc
  statement.cc
  win_delay_load_hook.cc
Failed to execute 'C:\Program Files (x86)\nodejs\node.exe C:\Program Files (x86)\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js build --fallback-to-build --module=C:\projects\loopback-next\extensions\typeorm\node_modules\sqlite3\lib\binding\napi-v6-win32-ia32\node_sqlite3.node --module_name=node_sqlite3 --module_path=C:\projects\loopback-next\extensions\typeorm\node_modules\sqlite3\lib\binding\napi-v6-win32-ia32 --napi_version=7 --node_abi_napi=napi --napi_build_version=6 --node_napi_label=napi-v6' (1)

@bajtos
Copy link
Member

bajtos commented Jan 12, 2021

Possibly related: TryGhost/node-sqlite3#1424

@renovate renovate bot force-pushed the renovate/sqlite3-5.x branch from e7aaf16 to 7b9ab38 Compare January 20, 2021 23:20
@renovate renovate bot requested review from bajtos and raymondfeng as code owners January 20, 2021 23:20
@renovate renovate bot force-pushed the renovate/sqlite3-5.x branch from 7b9ab38 to e9d43b1 Compare January 21, 2021 13:15
@renovate renovate bot force-pushed the renovate/sqlite3-5.x branch 6 times, most recently from c33d1e9 to 947312f Compare February 10, 2021 17:21
@renovate renovate bot force-pushed the renovate/sqlite3-5.x branch from 947312f to d1e2e78 Compare February 15, 2021 21:50
@renovate renovate bot changed the title chore: update dependency sqlite3 to ^5.0.1 chore: update dependency sqlite3 to ^5.0.2 Feb 15, 2021
@renovate renovate bot merged commit bf2400b into master Feb 15, 2021
@renovate renovate bot deleted the renovate/sqlite3-5.x branch February 15, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants