Repository navigation
fix: correct Chinese documentation SEO metadata and routes - #1
Merged
Merged
Conversation
zxch3n
marked this pull request as ready for review
September 30, 2026 04:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pages/so they no longer become public routes; preserve helper bytes and update imports.https://cn.loro.dev.This preserves the finalized reviewed patch. The generated RSS diff is large because previously tracked feeds contained English bodies; regenerated feeds now reflect existing Chinese source. Four existing bare
<=1.7.xprose literals are wrapped in inline code to fix baseline Nextra parsing, without changing technical meaning or code examples.Validation
Completed against baseline
24c9bc9ce66e358029787f49358eebb27e3fd328:node --test scripts/seo.test.mjs— 6 tests, including actual Nextra MDX compilation of the affected API/event filesnode_modules/.bin/tsc --noEmit --incremental falseCIRCLE_NODE_TOTAL=2 NEXT_TELEMETRY_DISABLED=1 npm run build— RSS generation, Next production build/static generation, sitemap and rendered SEO checksgit diff --checkand clean patch applicability against the exact baseline; helper files are 100% renamesValidation limits
Locally, the existing Deno documentation-example suite was attempted twice, but both attempts stopped fetching
https://jsr.io/@std/fs/meta.jsonbefore examples ran.After publication, GitHub Actions run
36666548388for head03eac25c648d09f00c7d63f1b8e8c4076e28b1b9completed and was marked successful. However, its job log reports 122 examples: 121 passed, 1 failed. The failure is the existing bareloro-mirrorimport inpages/blog/loro-mirror.mdx:71, which Deno cannot resolve. The failing example anddeno_scripts/run_code_blocks.tsare unchanged from the baseline; this PR only fixes the author link in that article. The existing runner counts failures without returning a failing exit code, so the green workflow does not mean the full snippet suite passed. Those unrelated issues are left outside this SEO patch.The successful build used one Next worker via
CIRCLE_NODE_TOTAL=2in the memory-constrained validation environment. Existing read-only global Git config, outdated Browserslist data and WASM async/await warnings remain. No dependency lockfile or workspace configuration changes are included.Draft for review; no merge or deployment has been performed.