Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
When i work on my game, i try to use A*, and in a moment start to refactor tiles.py :)
First of all, i merge changes of #304, so my refactoring based on this.
Commonly, i split code of
load_tmx
to "screen-fitting" size function and this refactor has fix some issues with loading.For example, with next map(created with Tiled), that has separated tileset file can't be loaded. It's crash with "UnboundLocalError: local variable 'tileset' referenced before assignment".
I attach all that needed to reproduce this:
In my case, it's files on Koraken branch "tiles-301", and origin versions "0.6.6", "0.6.5".
I'm check utests, but no changes. 18 fails as was before my changes. Looks like there is no tests for loading tiled maps :). I'm going to write tests in future.
So , changes lie in my fork, i create PR from dev to master for easy review. I will be very grateful for the review.