Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of refactoring #312

Closed
wants to merge 15 commits into from
Closed

Review of refactoring #312

wants to merge 15 commits into from

Conversation

Intey
Copy link

@Intey Intey commented Jun 15, 2018

Hello.
When i work on my game, i try to use A*, and in a moment start to refactor tiles.py :)
First of all, i merge changes of #304, so my refactoring based on this.
Commonly, i split code of load_tmx to "screen-fitting" size function and this refactor has fix some issues with loading.
For example, with next map(created with Tiled), that has separated tileset file can't be loaded. It's crash with "UnboundLocalError: local variable 'tileset' referenced before assignment".
I attach all that needed to reproduce this:

  1. put *.png, *.tsx, *.tmx in directory assets in test-root
  2. put testing.py in test-root
  3. create env, install cocos2d(0.6.5+)
  4. run "python testing.py"

In my case, it's files on Koraken branch "tiles-301", and origin versions "0.6.6", "0.6.5".

I'm check utests, but no changes. 18 fails as was before my changes. Looks like there is no tests for loading tiled maps :). I'm going to write tests in future.

So , changes lie in my fork, i create PR from dev to master for easy review. I will be very grateful for the review.

@Intey Intey closed this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants