Merge pull request #49 from losisin/feature/set-items-type-in-array

Set Items type in array with schema annotation
losisin · Mar 11, 2024 · 3c5f905 · 3c5f905
2 parents d663707 + a6bc339
commit 3c5f905
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/pkg/schema.go b/pkg/schema.go
@@ -172,6 +172,10 @@ func processComment(schema *Schema, comment string) (isRequired bool) {
 				if err := json.Unmarshal([]byte(value), &jsonObject); err == nil {
 					schema.Default = jsonObject
 				}
+			case "item":
+				schema.Items = &Schema{
+					Type: value,
+				}
 			}
 		}
 	}

diff --git a/pkg/schema_test.go b/pkg/schema_test.go
@@ -297,8 +297,8 @@ func TestProcessComment(t *testing.T) {
 		{
 			name:             "Set array",
 			schema:           &Schema{},
-			comment:          "# @schema minItems:1;maxItems:10;uniqueItems:true",
-			expectedSchema:   &Schema{MinItems: uint64Ptr(1), MaxItems: uint64Ptr(10), UniqueItems: true},
+			comment:          "# @schema minItems:1;maxItems:10;uniqueItems:true;item:boolean",
+			expectedSchema:   &Schema{MinItems: uint64Ptr(1), MaxItems: uint64Ptr(10), UniqueItems: true, Items: &Schema{Type: "boolean"}},
 			expectedRequired: false,
 		},
 		{

diff --git a/testdata/full.schema.json b/testdata/full.schema.json
@@ -111,6 +111,12 @@
             ],
             "type": "object"
         },
+        "imagePullSecrets": {
+            "items": {
+                "type": "object"
+            },
+            "type": "array"
+        },
         "nameOverride": {
             "type": "string"
         },

diff --git a/testdata/full.yaml b/testdata/full.yaml
@@ -18,6 +18,8 @@ replicas: 2 # @schema minimum: 1 ; maximum: 10 ; multipleOf: 2
 fullnameOverride: bar # @schema pattern: ^[a-z]$ ; title: My title
 
 # Arrays
+imagePullSecrets: [] # @schema item: object
+
 tolerations: # @schema minItems: 1 ; maxItems: 10 ; uniqueItems: true
   - key: "bar"
     operator: "Equal"