Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from our SA #90

Merged
merged 40 commits into from
Jan 29, 2025
Merged

Conversation

StefanieJaeger
Copy link
Member

@StefanieJaeger StefanieJaeger commented Jan 15, 2025

This PR contains all changes made during our SA as well as some smaller bug fixes made later on.
I would recommend to first merge this PR, so we can use the newest tag of the normal data repo, instead of having to reference our fork of the data repo.
Closes #49 and closes #66.

StefanieJaeger and others added 24 commits September 18, 2024 10:02
* Add link to Studienordnung

* Clean up
* Add Module from Focus

* Use constructor

* Adding from Focus works

* Basic functionality

* Move Categories to own component

* Style button for focus

* Style button

* Clean up

* Add toggle for validation

* Styling

* Disable semester button

* Work on validation, need data store

* Introduce store

* Get validation working

* WIP

* Add validation for semester

* Validation

* Style errors

* Add global validation info

* Validation and actions work

* Fix todo

* Fix lint

* Rename

* Clean up

* Fixes

* Fix lint
* Add Module from Focus

* Use constructor

* Adding from Focus works

* Basic functionality

* Move Categories to own component

* Style button for focus

* Style button

* Clean up

* Add toggle for validation

* Styling

* Disable semester button

* Work on validation, need data store

* Introduce store

* Get validation working

* WIP

* Add validation for semester

* Validation

* Style errors

* Add global validation info

* Validation and actions work

* Fix todo

* Fix lint

* Rename

* Clean up

* Fixes

* Add search

* Fix lint

* Clean

* Search by id

* Make switch and alert stick

* Lint
* Store accredited modules in url

* Add accredited module

* Fix bug

* WIP

* Validate accredited modules

* Store accredited modules properly

* Include in cateogires

* WIP

* Clean

* Lint

* Move button

* Fix dropdown in modal for Chrome

* Show label

* Show feedback for error in name

* Set focus

* Add comment and rename

* Fix scroll

* Add class

* Sort cats

* Fixes

* Lint
* Fix search problem

* Show modules outside a category

* Fix lint
@StefanieJaeger
Copy link
Member Author

StefanieJaeger commented Jan 15, 2025

Closes #49 and closes #66

Copy link
Member

@jeremystucki jeremystucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the size of this PR I can't give a thorough review. Let's wait a few days to see if someone else want to take a look and otherwise we merge it and see what happens.

Should we add a link to old.lost.university in case this breaks something?

@jeremystucki
Copy link
Member

Closes issues #49 and #66

GitHub uses specific syntax to close issues automatically. Please adjust the comment accordingly.

@jeremystucki
Copy link
Member

jeremystucki commented Jan 20, 2025

Please apply the following two patches.

Enabling title attributes on mobile

diff --git a/src/components/Module.vue b/src/components/Module.vue
index 19aabb8..9228a55 100644
--- a/src/components/Module.vue
+++ b/src/components/Module.vue
@@ -8,12 +8,14 @@
       <span
         v-if="module.validationInfo && module.validationInfo.severity === 'soft'"
         :title="module.validationInfo.tooltip"
+        tabindex="0"
       >
         <font-awesome-icon :icon="['fa', 'info-circle']" />
       </span>
       <span
         v-if="module.validationInfo && module.validationInfo.severity === 'hard'"
         :title="module.validationInfo.tooltip"
+        tabindex="0"
       >
         <font-awesome-icon :icon="['fa', 'circle-exclamation']" />
       </span>
diff --git a/style.css b/style.css
index b5c61c9..257c07c 100644
--- a/style.css
+++ b/style.css
@@ -1,3 +1,22 @@
 @tailwind base;
 @tailwind components;
 @tailwind utilities;
+
+@media (hover: none) {
+    [title] {
+        position: relative;
+        display: inline-flex;
+        justify-content: center;
+    }
+    [title]:focus::after {
+        content: attr(title);
+        position: absolute;
+        top: 90%;
+        color: #000;
+        background-color: #fff;
+        border: 1px solid;
+        width: fit-content;
+        padding: 3px;
+        z-index: 99;
+    }
+}

Adding a banner to the footer

diff --git a/src/components/PageFooter.vue b/src/components/PageFooter.vue
index 853d6bf..18b6b4a 100644
--- a/src/components/PageFooter.vue
+++ b/src/components/PageFooter.vue
@@ -26,6 +26,16 @@
       />
     </a>
   </footer>
+  <div class="bg-[#8c195f] text-white text-center py-4">
+    <span class="font-bold">
+      Die Webseite wurde kürzlich im Rahmen einer SA überarbeitet und hat jetzt ein paar neue Features
+    </span>
+    <br />
+    <span class="text-sm">
+      Falls etwas nicht funktionieren sollte, eröffne bitte ein Issue <a href="https://github.com/lost-university/web/issues/new/choose"><u>auf GitHub.</u></a>
+      Die vorherige Version ist unter <a href="https://old.lost.university"><u>old.lost.university</u></a> weiterhin für eine begrenzte Zeit verfügbar.
+    </span>
+  </div>
 </template>
 
 <script lang="ts">

@StefanieJaeger StefanieJaeger added this pull request to the merge queue Jan 29, 2025
Merged via the queue into lost-university:main with commit 7d2e79d Jan 29, 2025
2 checks passed
@StefanieJaeger StefanieJaeger deleted the SJ/after-sa branch January 29, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding modules on iOS is broken Add categories to module selector
3 participants