-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from our SA #90
Changes from our SA #90
Conversation
* Add link to Studienordnung * Clean up
* Use tailwind classes
* Add Module from Focus * Use constructor * Adding from Focus works * Basic functionality * Move Categories to own component * Style button for focus * Style button * Clean up * Add toggle for validation * Styling * Disable semester button * Work on validation, need data store * Introduce store * Get validation working * WIP * Add validation for semester * Validation * Style errors * Add global validation info * Validation and actions work * Fix todo * Fix lint * Rename * Clean up * Fixes * Fix lint
* Add Module from Focus * Use constructor * Adding from Focus works * Basic functionality * Move Categories to own component * Style button for focus * Style button * Clean up * Add toggle for validation * Styling * Disable semester button * Work on validation, need data store * Introduce store * Get validation working * WIP * Add validation for semester * Validation * Style errors * Add global validation info * Validation and actions work * Fix todo * Fix lint * Rename * Clean up * Fixes * Add search * Fix lint * Clean * Search by id * Make switch and alert stick * Lint
* Store accredited modules in url * Add accredited module * Fix bug * WIP * Validate accredited modules * Store accredited modules properly * Include in cateogires * WIP * Clean * Lint * Move button * Fix dropdown in modal for Chrome * Show label * Show feedback for error in name * Set focus * Add comment and rename * Fix scroll * Add class * Sort cats * Fixes * Lint
* Fix search problem * Show modules outside a category * Fix lint
* Fix styling * Lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the size of this PR I can't give a thorough review. Let's wait a few days to see if someone else want to take a look and otherwise we merge it and see what happens.
Should we add a link to old.lost.university
in case this breaks something?
GitHub uses specific syntax to close issues automatically. Please adjust the comment accordingly. |
Please apply the following two patches. Enabling title attributes on mobile
Adding a banner to the footer
|
This PR contains all changes made during our SA as well as some smaller bug fixes made later on.
I would recommend to first merge this PR, so we can use the newest tag of the normal data repo, instead of having to reference our fork of the data repo.
Closes #49 and closes #66.