Allow specifying methods that bypass :retry_if on Request::Retry #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraday::Request::Retryis not needed, please merge my pull-request to your fork here. |
…nt-methods clean constant IDEMPOTENT_METHODS
|
@rusikf Merged your PR, thanks. |
|
Do I need to provide any more info or changes for this pull request? |
technoweenie
added a commit
that referenced
this pull request
Jan 7, 2015
…dempotent-methods Allow specifying methods that bypass :retry_if on Request::Retry
|
Thanks for the patch! Just FYI, I'm replacing Faraday with a new lib: Hurley. #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the
IDEMPOTENT_METHODSfunctionality to allow speifying themethods that will be retried without calling
:retry_if. The new:methodsoptionto
Request::Retryallows:retry_ifto be called for every HTTP method, a user-specified set of HTTP methods, or never.
It's likely that
:retry_if,IDEMPOTENT_METHODS, and:methodscould becombined into a simpler API (such as by changing the
:retry_ifdefault value tocheck for an idempotent method), but this separate approach preserves the
existing behavior if
:methodsis not specified.Tests and documentation are included in the pull request; I ran the tests against
Ruby 2.1.3 and Ruby 1.8.7.