Swap out Faraday for Hurley #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| require 'faraday' | |||
| require 'hurley' | |||
| require 'addressable/template' | |||
There was a problem hiding this comment.
Should we require addressable-uri before hurley? Since we're using Addressable anyway, might as well use it for URI parsing too.
| def initialize(endpoint, options = nil) | ||
| @endpoint = endpoint | ||
| @conn = (options && options[:faraday]) || Faraday.new | ||
| @client = (options && options[:hurley]) || Hurley::Client.new(@endpoint) |
There was a problem hiding this comment.
Since we are renaming the option why not use :client?
There was a problem hiding this comment.
I like :client 👍 Hurley means nothing to me. I'll replace him with Ben in a heartbeat!
Callers shouldn't care if we're using Hurley by default. /cc @rafaelfranca
Instead of totally ripping out Faraday, this change provides an incremental compatibility layer on top of Hurley so folks can use either library.
|
@technoweenie: What do you think of 6a16a00. |
Since we're already using Addressable, this will let Hurley use it for URI parsing.
|
Since Faraday is being deprecated, I'd prefer that Faraday gets a shim for Hurley API compatibility instead :) |
|
@technoweenie Check out the latest diff. |
|
Looks like Faraday is here to stay. lostisland/hurley#43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See lostisland/faraday#454.
This moves Sawyer over from Faraday internals to the new Hurley project. Will wait until we get Octokit.rb running against this branch before thinking about merging.
/fyi @technoweenie