Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable yaml tests in Ruby 2.5+ because of issues with Psych 3.0 #63

Merged
merged 2 commits into from
May 1, 2019

Conversation

technoweenie
Copy link
Member

This should get the tests green and out of the CI "allowed failures" set. Also checks a SAWYER_YAML_ENABLED env var to run those tests anyway.

$ SAWYER_YAML_ENABLED=1 rake
/Users/rick/.rbenv/versions/2.5.3/bin/ruby -w -I"lib:lib:test" -I"/Users/rick/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/rake-12.3.2/lib" "/Users/rick/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/rake-12.3.2/lib/rake/rake_test_loader.rb" "test/agent_test.rb" "test/relation_test.rb" "test/resource_test.rb" "test/response_test.rb"
Run options: --seed 36173

# Running:

...E.....WARNING: Unexpected middleware set after the adapter. This won't be supported from Faraday 1.0.
..................................E......

Finished in 0.513981s, 97.2799 runs/s, 400.7930 assertions/s.

  1) Error:
Sawyer::AgentTest#test_handle_yaml_dump_and_load:
TypeError: allocator undefined for Method

/cc #54

@technoweenie technoweenie merged commit f2ec34d into master May 1, 2019
@technoweenie technoweenie deleted the disable-yaml-ruby-2.5 branch May 1, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant