Avoid temp dir creation at import time for DefaultOptions#179
Open
sfmqrb wants to merge 1 commit intolotusdblabs:mainfrom
Open
Avoid temp dir creation at import time for DefaultOptions#179sfmqrb wants to merge 1 commit intolotusdblabs:mainfrom
sfmqrb wants to merge 1 commit intolotusdblabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #177 by making temporary DB directory creation lazy.
Problem
DefaultOptionscurrently callstempDBDir()during package initialization, which creates a new temp directory even if the caller never opens a DB.Changes
DefaultOptions.DirPathis now initialized to an empty string.validateOptionsnow lazily assignstempDBDir()whenDirPathis empty.TestDBOpento verify that opening with emptyDirPathsucceeds and gets a generated directory.Behavior after this PR
Openis called with noDirPath.Validation
go test ./...passes locally in this environment.