-
-
Notifications
You must be signed in to change notification settings - Fork 667
Fix "Exited" Status when Expected #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This should fix louislam#806
Merged @Aymendje's pull request that fixes the "Exited" status when container exited as expected (ie init containers)
|
Hello, Your change seems to be generating the error reported in cmcooper1980#24. Could you please look into a fix? Thank you. |
|
@boced66 thank you for the report |
|
@Aymendje Thank you for the pr and your further fixes. With my The logs when starting the stack: |
|
Sorry about it, I had a quote in a spwn, which does not work |
Signed-off-by: Aymen Djellal <[email protected]>
|
Hi @Aymendje. I created a fork of the cmcooper repo and applied this latest patch to stack.ts but unfortunately am still running into the same issue. |
|
@mbaran5 I think I added some logging around this, could you check what are the console logs when you hit the issue ? |
This should fix #806
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:
Description
When deploying the Docker stack, the status is displayed as "Exited" because one of the containers, which is designed to run only once during startup (e.g., a migration job), is not running.
This PR adds a check to list exited containers, and verify if they exited with error code 0 (OK) or something else (NOT OK)
Fixes #(issue)
#806
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.