feat: implement incident history #6469

aluminyoom · 2025-12-09T00:03:54Z

📋 Overview

What problem does this pull request address?

This PR adds an Incident Timeline/History feature to status pages with basic management (EDIT/RESOLVE/DELETE). This implementation is designed to be minimal to allow building upon so we don't introduce further feature bloat. Additionally, this PR enables multiple pinned/active incidents.

What features or functionality does this pull request introduce or enhance?

This PR allows a status page to have multiple pinned/active incidents as opposed to previously one. Basically change (findOne -> find)

This PR shows the past incidents grouped by date (if existing) reusing the existing incidents table for now.
Incident Management is PER status page NOT global. The past incidents page loads progressively via the Load More button.

The management side of past incidents are in the incident history itself, it feels native as incidents are managed per status page.

Re: Pinning and unpinning

You can unpin/pin an active incident by going into the history > edit > uncheck pin
You cannot pin a resolved incident

~~nit(unrelated/noise): changed slug is not found -> slug not found~~ (removed in 1395388)

~~nit(maintainability): const INCIDENT_PAGE_SIZE = 10; move to util.ts~~ (addressed 2a360ef)

nit(unrelated): running npm run tsc produced unrelated changes to my change in util.ts, not sure if i should keep it.

This PR used an LLM to generate and format JSDoc comments.
This PR used an LLM to generate review comments and some of those comments have been accepted via Copilot.

Resolves [Feature]: Incident Timeline #862
Resolves Feature Req: Multiple Incidents on Status Page #579

🛠️ Type of change

✨ New feature (a non-breaking change that adds new functionality)
🎨 User Interface (UI) updates

📄 Checklist

🔍 My code adheres to the style guidelines of this project.
🦿 I have indicated where (if any) I used an LLM for the contributions
✅ I ran ESLint and other code linters for modified files.
🛠️ I have reviewed and tested my code.
📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
⚠️ My changes generate no new warnings.
🔒 I have considered potential security impacts and mitigated risks.
📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

Multiple Pinned Incidents

Incident Timeline/History

Copilot

Pull request overview

This PR implements an incident timeline/history feature for status pages, enabling multiple pinned/active incidents and providing basic management capabilities (edit, resolve, delete). The implementation changes the existing single-incident model to support multiple active incidents, adds a paginated incident history view, and introduces new UI components for incident management.

Key Changes:

Changed from single incident (findOne) to multiple active incidents (find) with pinning support
Added paginated incident history with progressive loading via "Load More" button
Implemented per-status-page incident management through both inline editing and modal interfaces

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/pages/StatusPage.vue	Added incident history display with pagination, multiple active incidents support, inline editing for active incidents, and new methods for incident management
src/components/IncidentHistory.vue	New component displaying incident list with edit/delete/resolve actions for authenticated users
src/components/IncidentManageModal.vue	New modal component for editing incidents from the history section
src/lang/en.json	Added translation keys for incident history UI elements and validation messages
server/socket-handlers/status-page-socket-handler.js	Added socket handlers for incident history retrieval, editing, deletion, and resolution with input validation
server/routers/status-page-router.js	Added REST API endpoint for public incident history access with pagination
server/model/status_page.js	Changed incident retrieval from single to multiple active pinned incidents
server/model/incident.js	Added `resolve()` method and `toJSON()` method for admin data serialization

Comments suppressed due to low confidence (1)

src/pages/StatusPage.vue:211

The dropdown button has a duplicate ID "dropdownMenuButton1" which appears on lines 208 and 254. HTML IDs must be unique within a document. This can cause accessibility issues and incorrect behavior with Bootstrap dropdowns.

Use unique IDs for each dropdown, such as:

Line 208: id="dropdownMenuButton-new"
Line 254: id="dropdownMenuButton-edit"

And update the corresponding aria-labelledby attributes on lines 211 and 257.

                        <button id="dropdownMenuButton1" class="btn btn-secondary dropdown-toggle" type="button" data-bs-toggle="dropdown" aria-expanded="false">
                            {{ $t("Style") }}: {{ $t(incident.style) }}
                        </button>
                        <ul class="dropdown-menu" aria-labelledby="dropdownMenuButton1">

server/socket-handlers/status-page-socket-handler.js

server/routers/status-page-router.js

src/components/IncidentHistory.vue

src/pages/StatusPage.vue

server/socket-handlers/status-page-socket-handler.js

src/pages/StatusPage.vue

aluminyoom · 2025-12-09T00:21:54Z

converting to draft to double check copilots review

update incorrect translation add resolved translation use translation for unk remove duplicate load fix state management for cancelling edit propagate error if unable to load incident history (unlikely) fix xss

demidovegor · 2025-12-09T20:56:45Z

@aluminyoom Great work!

However, I noticed that this PR only addresses the issue with displaying multiple incidents. In #862, the author previously suggested an approach commonly used by other status page services — not a literal visual timeline, but rather a series of incident update messages (start, intermediate updates, resolution). Their timeline mockup was admittedly bulky, but the idea behind message-based incident updates is a well-established pattern in many status pages.

It might be worth considering this direction as well.

aluminyoom · 2025-12-10T00:52:39Z

Thanks, @demidovegor

This PR can definitely go in that direction, and I agree and would have done so if not for the DB schema changes it would require. The goal for this PR is to have a barebones Incident History that utilizes the existing schema while making it possible to extend in the future so other people can build on top of it (in your case, supporting the intermittent updates)

Can definitely introduce a stacked pr on top of this change, with the schema changes and the in-betweeners: start, intermediate updates, resolution.

fix dry violations and revert nit move to util.ts

CommanderStorm

Sorry, I have been super buisy over the holidays.
Code looks good and is well structured 🎉

I have some minor comments, but nothing major.

I have two blocking issues:

this is a constant 10 incidents on each status page that uses incidents, which is fairly long. Can we move the exact current UI into a modal (maybe better? not sure?) or should we shorten this to something like 2? 🤔
I think there is a bug that the current active incidents are also shown under "Past incidents"

CommanderStorm · 2025-12-25T01:23:50Z

server/model/incident.js

+    toJSON() {
+        return {
+            ...this.toPublicJSON(),
+            status_page_id: this.status_page_id,


I don't consider this quite internal, or am I missing something? 🤔
Can't this just be added to toPublicJSON?

definitely trivial yea, reasoning behind this is to expose the only needed data for public endpoints. since status_page_id doesn't really get consumed on the public facing side.

we can add it to toPublicJSON but it would be unused for public endpoints.

edit: formatting

lets simplify this then to just include it up in toPublicJSON.

CommanderStorm · 2026-01-03T03:19:01Z

server/model/status_page.js

+    static async getIncidentHistory(statusPageId, page, isPublic = true) {
+        const offset = (page - 1) * INCIDENT_PAGE_SIZE;
+
+        const incidents = await R.find("incident",
+            " status_page_id = ? ORDER BY created_date DESC LIMIT ? OFFSET ? ",
+            [ statusPageId, INCIDENT_PAGE_SIZE, offset ]
+        );


instead of offset based, can we make it created_date based?

Here is a blogpost explaining the rationale and why limit/offset is usually buggy.
https://cedardb.com/blog/pagination/

thats a very interesting and great read. i'll go ahead and do that, thanks!

CommanderStorm · 2026-01-03T03:29:11Z

server/socket-handlers/status-page-socket-handler.js

        }
    });

+    socket.on("getIncidentHistory", async (slug, page, callback) => {


getIncidentHistory and getPublicIncidentHistory only differ in the one checking for login and one true/false.
Can we merge them into one where true/false is set based on the login status?

CommanderStorm · 2026-01-03T03:33:49Z

src/pages/StatusPage.vue

            </div>

+            <!-- Past Incidents -->
+            <div class="past-incidents-section mb-4">


I don't quite know where this bug is from, but this section also includes the currently active, not just the past incidents.

Can we only have the past incidents here?

ah yea, my reasoning for this one is to include ongoing incidents under past incidents as well.

for me it seemed logical to put it there as the "past incidents" view is a historical timeline of all incidents, and having a pinned incident should still show on history don't you think?

for reference the "bug" is this located here. we don't filter out by status and return the incidents regardless of state.

Well if they are "Past", that means that they are sort of historical, right?
I think the currently actively pinned are not historical.

I would not include them down there.
Alternatively, we can change the label, but I think most people would expect it to not be there.

@demidovegor maybe you can give your oppinion on this

cc'ing the original issue creator as well for input: @14wkinnersley

I could see this go both ways. I would prefer the "Past Incidents" to show actual past and not a duplicate of the current ongoing incidents. I did initially find that confusing when I was testing, but it didn't bother me having it shown there since it was designed in a way you can clearly differentiate which are active incidents and which are old. Id prefer it not to be duplicated though

CommanderStorm · 2026-01-03T03:44:53Z

Also could you add some e2e tests for this functionality?
Incidents are currently not well covered by this, so we would not detect accidental breakage in this part 😓

CommanderStorm · 2026-01-03T03:47:49Z

src/components/IncidentHistory.vue

+            </div>
+        </div>
+
+        <div v-else-if="incidents.length === 0" class="text-center py-4 text-muted">


I would not show the entire history in this case, as I assume that the vast majority of our users don't use this feature (communicating status acively is sadly less common I think).

-> Should we hide it? what do you think is better overall?

for minimalism (my bias), i'd prefer to hide it. though keeping it shows that incident history is a thing and shows reliability.

i guess keeping it an option would be better (default is to not show history)? but that would be touching the other components already. for this case i'd keep it then implement the option later

for minimalism (my bias), i'd prefer to hide it

Then lets do that 😉

aluminyoom · 2026-01-19T19:06:08Z

^ changes

cursor-based pagination
make past incidents past incidents
merge public/authenticated incident history socket handlers into one
hide past incidents if nothing there
e2e

todo:

utils issue merge conflict

multiple active incidents

past incidents

no longer shows active incidents

empty/no incidents

no longer shows past incidents if empty

management

still the same old

CommanderStorm

LGTM, we can merge when you want (the PR is currently still a draft)

aluminyoom · 2026-01-19T23:33:45Z

okie dokie undrafted

aluminyoom · 2026-01-19T23:57:54Z

will fix

aluminyoom · 2026-01-20T02:26:15Z

converting to draft (have to resolve e2e failures)

github-actions · 2026-01-20T06:03:21Z

@aluminyoom congrats on your first contribution to Uptime Kuma! 🐻
We hope you enjoy contributing to our project and look forward to seeing more of your work in the future! If you want to see your contribution in action, please see our nightly builds here.

aluminyoom added 2 commits December 9, 2025 07:36

incident history foundation

1a9748d

format translations

11a9414

aluminyoom marked this pull request as ready for review December 9, 2025 00:11

Copilot AI review requested due to automatic review settings December 9, 2025 00:11

Copilot started reviewing on behalf of aluminyoom December 9, 2025 00:11 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

aluminyoom marked this pull request as draft December 9, 2025 00:19

aluminyoom marked this pull request as ready for review December 9, 2025 00:53

aluminyoom marked this pull request as draft December 9, 2025 00:54

address review comments

71f32ae

update incorrect translation add resolved translation use translation for unk remove duplicate load fix state management for cancelling edit propagate error if unable to load incident history (unlikely) fix xss

aluminyoom force-pushed the feature/incident-history branch from 5e1c1d8 to 71f32ae Compare December 9, 2025 00:57

aluminyoom marked this pull request as ready for review December 9, 2025 01:03

Merge branch 'master' into feature/incident-history

c730f39

aluminyoom marked this pull request as draft December 10, 2025 01:14

address self-review comments

1057cc9

fix dry violations and revert nit move to util.ts

aluminyoom force-pushed the feature/incident-history branch from 2a360ef to 1057cc9 Compare December 10, 2025 01:43

aluminyoom marked this pull request as ready for review December 10, 2025 01:48

CommanderStorm mentioned this pull request Dec 12, 2025

[Feature]: Incident Timeline #862

Closed

1 task

CommanderStorm mentioned this pull request Dec 22, 2025

Feature Req: Multiple Incidents on Status Page #579

Closed

CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label Dec 23, 2025

CommanderStorm requested changes Jan 3, 2026

View reviewed changes

Merge branch 'master' into feature/incident-history

9e000ae

CommanderStorm reviewed Jan 3, 2026

View reviewed changes

CommanderStorm changed the title ~~implement incident history~~ feat: implement incident history Jan 3, 2026

CommanderStorm added this to the 2.2.0 milestone Jan 3, 2026

CommanderStorm removed the pr:needs review this PR needs a review by maintainers or other community members label Jan 3, 2026

CommanderStorm approved these changes Jan 19, 2026

View reviewed changes

github-actions bot removed the needs:resolve-merge-conflict label Jan 19, 2026

aluminyoom marked this pull request as ready for review January 19, 2026 23:31

github-actions bot added pr:needs review this PR needs a review by maintainers or other community members and removed pr:please address review comments this PR needs a bit more work to be mergable labels Jan 19, 2026

Merge branch 'master' into feature/incident-history

8076275

CommanderStorm enabled auto-merge (squash) January 19, 2026 23:44

CommanderStorm modified the milestones: 2.2.0, 2.1.0 Jan 19, 2026

[autofix.ci] apply automated fixes

fea823d

aluminyoom marked this pull request as draft January 19, 2026 23:57

auto-merge was automatically disabled January 19, 2026 23:57
Pull request was converted to draft

aluminyoom marked this pull request as ready for review January 20, 2026 00:02

fix eslint disable comment

22bc222

aluminyoom marked this pull request as draft January 20, 2026 00:05

use existing i8n, change disable to multiline

c0a5ea8

aluminyoom marked this pull request as ready for review January 20, 2026 00:17

CommanderStorm enabled auto-merge (squash) January 20, 2026 00:39

fix e2e tests

ff084d6

auto-merge was automatically disabled January 20, 2026 01:55
Head branch was pushed to by a user without write access

aluminyoom marked this pull request as draft January 20, 2026 02:26

aluminyoom added 2 commits January 20, 2026 11:35

make stuff more consistent

79cc7e8

make e2e more targeted

5ed6804

aluminyoom marked this pull request as ready for review January 20, 2026 03:46

CommanderStorm merged commit 9169a64 into louislam:master Jan 20, 2026
26 checks passed

Uh oh!

feat: implement incident history #6469

feat: implement incident history #6469

Uh oh!

Conversation

aluminyoom commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Overview

What problem does this pull request address?

What features or functionality does this pull request introduce or enhance?

🛠️ Type of change

📄 Checklist

📷 Screenshots or Visual Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aluminyoom commented Dec 9, 2025

Uh oh!

demidovegor commented Dec 9, 2025

Uh oh!

aluminyoom commented Dec 10, 2025

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aluminyoom Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CommanderStorm commented Jan 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aluminyoom commented Jan 19, 2026

multiple active incidents

past incidents

empty/no incidents

management

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

aluminyoom commented Dec 9, 2025 •

edited

Loading

aluminyoom Jan 4, 2026 •

edited

Loading