[ac_range_check,dv] Included logging support in testbench #27645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisTheLuis
force-pushed
the
zR-ac-range-dv-log
branch
3 times, most recently
from
5721fd5 to
9994f54
Compare
martin-velay
requested changes
Jul 18, 2025
There was a problem hiding this comment.
Some comments are minors but some others will require some changes in order to make this DV robust in case of reuse in other context (refers to the hard coded values) and also to ensure proper checking (refers to illegal_bins).
But, this PR looks great in general!
| // Add individual case item for each csr | ||
| // TODO: Coverage sampling for interrupts should be moved to the CIP | ||
| // instead of it being performed in the scoreboard / predictor. Why it is | ||
| // implemented in such a manner must be examined. |
There was a problem hiding this comment.
That's a good question. I don't have the answer, but maybe it's because some IPs have to deal with it in special ways?
@rswarbrick, do you know?
| "intr_enable": begin | ||
| // FIXME TODO MVy | ||
| end | ||
| "intr_test": begin |
There was a problem hiding this comment.
Details
FYI, when you'll test the interrupts at port level, that's the way I've done it for the HMAC. It might not the best approach but I share it in case it may help:
hw/ip_templates/ac_range_check/dv/env/ac_range_check_predictor.sv
Outdated
Show resolved
Hide resolved
hw/ip_templates/ac_range_check/dv/env/ac_range_check_predictor.sv
Outdated
Show resolved
Hide resolved
hw/ip_templates/ac_range_check/dv/env/seq_lib/ac_range_check_smoke_vseq.sv
Outdated
Show resolved
Hide resolved
hw/ip_templates/ac_range_check/dv/env/seq_lib/ac_range_check_smoke_vseq.sv
Outdated
Show resolved
Hide resolved
hw/ip_templates/ac_range_check/dv/env/seq_lib/ac_range_check_smoke_vseq.sv
Outdated
Show resolved
Hide resolved
hw/ip_templates/ac_range_check/dv/env/seq_lib/ac_range_check_smoke_vseq.sv
Show resolved
Hide resolved
hw/ip_templates/ac_range_check/dv/env/seq_lib/ac_range_check_smoke_vseq.sv
Show resolved
Hide resolved
martin-velay
added
Component:DV
LouisTheLuis
force-pushed
the
zR-ac-range-dv-log
branch
7 times, most recently
from
5568d72 to
b6c984a
Compare
|
@Razer6 Can you comment on this, please? |
Razer6
reviewed
Aug 7, 2025
hw/ip_templates/ac_range_check/dv/env/ac_range_check_predictor.sv
Outdated
Show resolved
Hide resolved
LouisTheLuis
force-pushed
the
zR-ac-range-dv-log
branch
from
b6c984a to
f05b074
Compare
martin-velay
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
I think all my comments have been addressed properly, thanks @LouisTheLuis!
LouisTheLuis
force-pushed
the
zR-ac-range-dv-log
branch
5 times, most recently
from
0928421 to
871a966
Compare
LouisTheLuis
force-pushed
the
zR-ac-range-dv-log
branch
from
871a966 to
29f53b5
Compare
This commit includes covergroups for logging registers as well as introducing logging in the smoke sequence. Signed-off-by: LouisTheLuis <[email protected]>
LouisTheLuis
force-pushed
the
zR-ac-range-dv-log
branch
from
29f53b5 to
51dff19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes covergroups for logging registers as well as introducing logging in the smoke sequence.