Skip to content

Conversation

@rivos-eblot
Copy link

No description provided.

HW.

* `-c` specify a QEMU [configuration file](otcfg.md) from which to read all the cryptographic
constants. See [`cfggen.py`](cfggen.md) tool to generate such a file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
constants. See [`cfggen.py`](cfggen.md) tool to generate such a file.
constants. See the [`cfggen.py`](cfggen.md) tool to generate such a file.

### Arguments

* `-a` specify an alernative start address'
* `-a` specify an alernaltive start address'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo in a typo :)

Suggested change
* `-a` specify an alernaltive start address'
* `-a` specify an alternative start address'

Comment on lines 64 to 65
In the following example, `-chardev socket,id=spidev,host=localhost,port=8004,server=on,wait=off
-global ot-spi_device.chardev=spidev` should be added to the QEMU command line to create a TCP

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this command could be formatted in its own block split across lines to improve readability?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done.

error stream.
* `-i` / `--iface` select an alternative interface for listening on, default to localhost
* `-p` / `--port` select an altenative TCP port for listening on, default to 9000
* `-p` / `--port` select an altenaltive TCP port for listening on, default to 9000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative again 😅

Suggested change
* `-p` / `--port` select an altenaltive TCP port for listening on, default to 9000
* `-p` / `--port` select an alternative TCP port for listening on, default to 9000

@rivos-eblot rivos-eblot force-pushed the dev/ebl/md_rewrap_typos branch from c6ef4f4 to 9dcdc75 Compare November 4, 2025 16:06
@pamaury
Copy link

pamaury commented Nov 4, 2025

I try to follow the OT guideline which is that every new sentence (in Markdown) should start on a new line (I unfortunately messed up the first on the usbdev PR but this is fixed in the second one). This PR goes against this principle which I think is not ideal because it makes the diff/blame less useful.

@rivos-eblot
Copy link
Author

I try to follow the OT guideline which is that every new sentence (in Markdown) should start on a new line.

QEMU does not use Markdown but RestructuredText - which is similar. I have not found rules defining the format/syntax of .rst files, but it seems that existing files do not follow this rule.

@rivos-eblot
Copy link
Author

I try to follow the OT guideline which is that every new sentence (in Markdown) should start on a new line.

I can revert the change fot the USBDEV file if you think it is better.

For the pre-existing files, I think this rule makes the files harder to read in plain text.

@pamaury
Copy link

pamaury commented Nov 4, 2025

I try to follow the OT guideline which is that every new sentence (in Markdown) should start on a new line.

I can revert the change fot the USBDEV file if you think it is better.

For the pre-existing files, I think this rule makes the files harder to read in plain text.

Yes, can you revert the USBDEV ? This will at least avoid the merge conflict with the other PR

@rivos-eblot
Copy link
Author

Yes, can you revert the USBDEV ? This will at least avoid the merge conflict with the other PR

Done.

@rivos-eblot rivos-eblot force-pushed the dev/ebl/md_rewrap_typos branch from 9dcdc75 to b603eb0 Compare November 5, 2025 09:08
@rivos-eblot rivos-eblot force-pushed the dev/ebl/md_rewrap_typos branch from b603eb0 to a569416 Compare November 5, 2025 10:49
@rivos-eblot rivos-eblot merged commit d90d082 into lowRISC:ot-9.2.0 Nov 5, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants