Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/issue 577 Min.io S3 Plugin #582

Closed
wants to merge 4 commits into from

Conversation

esbolice
Copy link

@esbolice esbolice commented Dec 14, 2023

Proposed changes

This PR introduces a new feature to the MinIO S3 plugin within the Lowcoder project, aimed at enhancing its capabilities and integration. The feature is based on extensive tests conducted to ensure the robust functionality of the plugin, particularly focusing on the MinIO service's interaction and data handling.

Link to the discuss: https://discord.com/channels/1096896040159957084/1181235951796756543

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my feature is effective
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

The new feature includes:

  1. Enhanced CRUD operations for both text and binary files, ensuring efficient and accurate file handling.
  2. Improved file URL generation, facilitating better accessibility and integration with external applications.
  3. Rigorous data source configuration validation to maintain secure and reliable connections with the MinIO service.

This feature is designed to improve the overall functionality of the MinIO S3 plugin, providing a more robust and versatile tool for the Lowcoder project. The comprehensive test suite accompanying this feature ensures its reliability and readiness for integration into the main project.

Copy link

netlify bot commented Dec 14, 2023

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit db03725

FalkWolsky
FalkWolsky previously approved these changes Dec 14, 2023
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is truly fantastic...
Thank you very much for this valuable contribution!

@FalkWolsky
Copy link
Contributor

Screenshot 2023-12-14 at 20 57 11

Can we kindly ask you to look into it?
A test is failing. Everything else looks good!

@ludomikula ludomikula dismissed FalkWolsky’s stale review December 19, 2023 12:47

The merge-base changed after approval.

@FalkWolsky FalkWolsky changed the title Feat/issue 577 Feat/issue 577 Min.io S3 Plugin Jan 11, 2024
Copy link

netlify bot commented Mar 25, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit eee1bd6

@esbolice esbolice closed this by deleting the head repository Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants