Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete the locale file #752

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

cnelf
Copy link

@cnelf cnelf commented Mar 11, 2024

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

snowe2010 and others added 5 commits March 8, 2024 16:10
allow passing in an already dereferenced OpenAPI Document for plugins
that have large openapi specs like github. This takes the runtime for
Github from over 10s to ~1s on an M1 Max.

Adjust the github plugin to use this new capability by dereferencing on
plugin initialization, passing the derefed document to the runOpenApi
function.
optimize /runOpenApi to allow pre-dereferencing OpenAPI Spec
Copy link

netlify bot commented Mar 11, 2024

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9f0e484

FalkWolsky
FalkWolsky previously approved these changes Mar 11, 2024
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are so thankful for your help! We can only use machine translate - and surely never reach the quality of a perfect translation. Thank you very much für this valuable contribution!

@FalkWolsky FalkWolsky changed the base branch from main to dev March 11, 2024 10:44
@FalkWolsky FalkWolsky dismissed their stale review March 11, 2024 10:44

The base branch was changed.

Copy link

netlify bot commented Mar 11, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a722043

@FalkWolsky FalkWolsky merged commit a222250 into lowcoder-org:dev Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants