Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement oem type #130

Merged
merged 28 commits into from
Jul 18, 2024
Merged

Implement oem type #130

merged 28 commits into from
Jul 18, 2024

Conversation

matzipan
Copy link
Collaborator

@matzipan matzipan commented Jul 9, 2024

Closes #117

  • Add support for state vector parsing
  • Implement parser for state vector
  • Implement parser for covariance matrix
  • Add tests
  • Add rustdoc
  • Fix bug for missing segment
  • Add support for META_START/STOP
  • Implement construction for OemCovarianceMatrixType
  • Add support for COVARIANCE_START/STOP

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 98.23213% with 23 lines in your changes missing coverage. Please review.

Project coverage is 88.44%. Comparing base (4d9acef) to head (46235dd).
Report is 8 commits behind head on main.

Files Patch % Lines
crates/lox-io/src/ndm/kvn/parser.rs 95.51% 16 Missing ⚠️
crates/lox-io/src/ndm/oem.rs 99.35% 6 Missing ⚠️
crates/lox-io/src/ndm/common.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   84.92%   88.44%   +3.51%     
==========================================
  Files          84       84              
  Lines       37964    50981   +13017     
==========================================
+ Hits        32241    45090   +12849     
- Misses       5723     5891     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helgee
Copy link
Member

helgee commented Jul 12, 2024

Please prefix your branch names with your initials, e.g. az/implement_oem_type.

@matzipan matzipan force-pushed the implement_oem_type branch from 12c8e11 to 2b7c0de Compare July 14, 2024 20:18
@matzipan matzipan force-pushed the implement_oem_type branch from 2b7c0de to 3c1a23e Compare July 14, 2024 20:21
@matzipan matzipan force-pushed the implement_oem_type branch 2 times, most recently from 57ef250 to 72acdf9 Compare July 15, 2024 08:23
@matzipan matzipan force-pushed the implement_oem_type branch from fbae63a to ed389d3 Compare July 15, 2024 21:39
matzipan added 3 commits July 15, 2024 23:49
The old one was like this because there used to be some filtering and
sorting. This was removed now
@matzipan matzipan force-pushed the implement_oem_type branch from d5c8bb6 to a360693 Compare July 16, 2024 23:17
@matzipan matzipan force-pushed the implement_oem_type branch from a360693 to af9f0b2 Compare July 16, 2024 23:17
@matzipan matzipan force-pushed the implement_oem_type branch 2 times, most recently from fe0888d to 9174016 Compare July 18, 2024 12:40
@matzipan matzipan force-pushed the implement_oem_type branch from 9174016 to 46235dd Compare July 18, 2024 12:41
@matzipan matzipan merged commit 3bb9ac9 into main Jul 18, 2024
42 checks passed
@helgee helgee deleted the implement_oem_type branch November 1, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the OEM KVN parser
2 participants