Skip to content

Manual body definitions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Manual body definitions #17

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b0ff3a
Define bodies manually
AngusGMorrison Nov 12, 2023
894615c
Fix missing conversion to radians for nut prec coefficients
AngusGMorrison Nov 12, 2023
5c1ea11
PR linting
AngusGMorrison Nov 12, 2023
8ef08d7
Align NaifId const name with previous convention
AngusGMorrison Nov 12, 2023
348efd7
Implement PR feedback
AngusGMorrison Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/target
/tools/*/target/
.venv/
.idea/*
.idea/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally succeeded in gitignoring the idea files successfully. May it rest in peace. Sorry about the extra PR noise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not really care before. This is the nuclear option which is certainly valid but it seems that JetBrains recommends to keep some of these files under version control: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair enough. It's a habitual response after years of culling .DS_Store and VSCode artifacts. I'm happy to default it.

8 changes: 0 additions & 8 deletions .idea/.gitignore
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/copyright/Lox.xml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions .idea/copyright/profiles_settings.xml
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions .idea/lox-space.iml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions .idea/modules.xml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/vcs.xml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/lox-space/src/prelude.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

pub use lox_core::bodies::barycenters::*;
pub use lox_core::bodies::planets::*;
pub use lox_core::bodies::{Ellipsoid, PointMass, Spheroid, TriAxial};
pub use lox_core::bodies::*;

pub use lox_core::time::dates::*;
pub use lox_core::time::epochs::*;
Expand Down
5 changes: 2 additions & 3 deletions crates/lox_core/src/bin/lox.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/

use lox_core::bodies::barycenters::MercuryBarycenter;
use lox_core::bodies::NaifId;
use lox_core::bodies::{MercuryBarycenter, NaifId};

fn main() {
println!("Hello LOX");
println!("{}", MercuryBarycenter::id())
println!("{}", MercuryBarycenter::NAIF_ID)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably just ::ID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

}
Loading