Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dynamic origins and frames #179

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Implement dynamic origins and frames #179

merged 1 commit into from
Dec 18, 2024

Conversation

helgee
Copy link
Member

@helgee helgee commented Dec 13, 2024

No description provided.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 58.62069% with 552 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (b42a3d9) to head (774096b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/lox-orbits/src/frames.rs 19.20% 122 Missing ⚠️
crates/lox-orbits/src/python.rs 0.00% 121 Missing ⚠️
crates/lox-orbits/src/states.rs 62.42% 65 Missing ⚠️
crates/lox-orbits/src/ground.rs 26.43% 64 Missing ⚠️
crates/lox-bodies/src/lib.rs 72.61% 46 Missing ⚠️
crates/lox-orbits/src/analysis.rs 22.80% 44 Missing ⚠️
crates/lox-orbits/src/elements.rs 48.97% 25 Missing ⚠️
crates/lox-orbits/src/frames/iers.rs 0.00% 21 Missing ⚠️
...ates/lox-orbits/src/propagators/semi_analytical.rs 48.38% 16 Missing ⚠️
crates/lox-bodies/src/python.rs 0.00% 14 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #179       +/-   ##
===========================================
- Coverage   87.94%   71.67%   -16.27%     
===========================================
  Files          85       83        -2     
  Lines       49065    21752    -27313     
===========================================
- Hits        43150    15591    -27559     
- Misses       5915     6161      +246     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #179 will improve performances by ×10

Comparing he/dyn-body (774096b) with main (b42a3d9)

Summary

⚡ 1 improvements

Benchmarks breakdown

Benchmark main he/dyn-body Change
test_visibility_benchmark 6,750.3 ms 665.3 ms ×10

@helgee helgee marked this pull request as ready for review December 18, 2024 16:02
@helgee helgee merged commit 52b82fb into main Dec 18, 2024
20 of 22 checks passed
@helgee helgee deleted the he/dyn-body branch December 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant