Add NaifId newtype and mapping to bodies #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngusGMorrison
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
This is great. Should be much smoother to work with bodies as a general category of object.
If you haven't read it already, I highly recommend Rust for Rustaceans, which covers object safety well (and much more besides). It's a bit light on examples, but very well written.
Could you please also reimplement lox_gen::naif_ids in terms of these newly box-able bodies? Currently we have two sources of truth.
| /// NaifId is implemented for all bodies. | ||
| pub trait NaifId: Copy { | ||
| const ID: i32; | ||
| pub trait Body { |
There was a problem hiding this comment.
I'm much happier with this implementation 🙂
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was quite the headache to make the body ZST object-safe but I was successful. Since neither associated constants nor static methods are allowed for trait objects, I needed to go back to instance methods. Unfortunately, this may be required in other places as well.