Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prefer Result over Option for Origin props #183

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

helgee
Copy link
Member

@helgee helgee commented Dec 19, 2024

No description provided.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 5.33708% with 337 lines in your changes missing coverage. Please review.

Project coverage is 71.52%. Comparing base (67a4555) to head (7ade492).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/lox-bodies/src/generated.rs 2.23% 263 Missing ⚠️
crates/lox-bodies/src/python.rs 0.00% 42 Missing ⚠️
crates/lox-bodies/src/lib.rs 27.58% 21 Missing ⚠️
crates/lox-orbits/src/states.rs 0.00% 5 Missing ⚠️
crates/lox-orbits/src/elements.rs 33.33% 2 Missing ⚠️
...ates/lox-orbits/src/propagators/semi_analytical.rs 33.33% 2 Missing ⚠️
crates/lox-orbits/src/ground.rs 66.66% 1 Missing ⚠️
crates/lox-orbits/src/python.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   71.67%   71.52%   -0.16%     
==========================================
  Files          83       83              
  Lines       21752    21799      +47     
==========================================
  Hits        15591    15591              
- Misses       6161     6208      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #183 will not alter performance

Comparing he/origin-result (7ade492) with main (67a4555)

Summary

✅ 1 untouched benchmarks

@helgee helgee merged commit 0cd59d0 into main Dec 19, 2024
18 of 20 checks passed
@helgee helgee deleted the he/origin-result branch December 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant