Conversation
matzipan
commented
Nov 22, 2023
matzipan
commented
Nov 22, 2023
matzipan
force-pushed
the
implement_leap_seconds
branch
2 times, most recently
from
f6858ff to
33c4e18
Compare
Contributor
AngusGMorrison
left a comment
AngusGMorrison
left a comment
There was a problem hiding this comment.
Largely looks good to me, but Helge will know better than me whether all the edge-case leap second insanity has been avoided 😅 I've left some minor comments. If you have any questions, let me know 🙂
| let mjd = tai_date_time.0 - MJD_EPOCH + tai_date_time.1; | ||
|
|
||
| // Before 1960-01-01 | ||
| if mjd < 36934.0 { |
matzipan
force-pushed
the
implement_leap_seconds
branch
from
33c4e18 to
c22185d
Compare
matzipan
force-pushed
the
implement_leap_seconds
branch
from
c22185d to
cbb2e80
Compare
matzipan
commented
Nov 26, 2023
helgee
reviewed
Nov 27, 2023
matzipan
force-pushed
the
implement_leap_seconds
branch
from
4b66f49 to
c5f21bc
Compare
This was referenced Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
offset_tai_utcCloses #16