fixed issue with bin generation in IMG2SP_CONVERT_BIN #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting an image to bin, the '.h.s' file was included into compilation, which generated .lst and .rel that where not deleted with 'make clean' or 'make cleanall'
|
Just found a commit of yours on 10 Aug 2018 "Fix:Produced h.s needed to be added to IMGASMFILES ", wich is the complete opposite of this patch. I don't know, maybe something else has changed in this time, or I am missing something. The issue is specially noticeable if the binary is saved outside src folder, as the 'sym rel rst lst' files of the '.h.s' are then created in the same folder of the bin file, not on 'obj', and are not deleted with make clean |
|
Sorry, I've closed this PR by accident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting an image to bin, the '.h.s' file was included into compilation, which generated unneeded lst, rst, rel and sym files that where not deleted with 'make clean' or 'make cleanall'