-
Notifications
You must be signed in to change notification settings - Fork 343
Development
: Add Hyperion admin setup docs
#11395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds new Hyperion Service documentation under admin setup, links it from the extension-services toctree, and references it from the developer server production setup guidance. No code, runtime, or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (3)
docs/admin/setup/hyperion.rst (3)
57-67
: Azure snippet: clarify deployment name vs. model; make temperature optional.In Azure,
deployment-name
must be the name of your Azure resource deployment (not the raw model name). Temperature is configurable, not mandated to be 1.0.Apply this diff:
spring: ai: azure: openai: api-key: <azure-openai-api-key> endpoint: https://<your-resource-name>.openai.azure.com chat: options: - deployment-name: <azure-deployment> # gpt-5-mini deployment recommended - temperature: 1.0 # Required to be 1.0 for gpt-5 + deployment-name: <your-azure-deployment-name> # the Azure deployment name you created (not the model name) + # model: <model-id> # optional; if supported by your Spring AI version + temperature: 1.0 # optional
71-76
: Verification: add fallback if management endpoint is disabled.If
/management/info
is not exposed, admins won’t seeactiveModuleFeatures
. Add a note about enabling the actuator info endpoint or alternatively checking logs at startup for “Hyperion enabled”.Would you like me to add a short “Troubleshooting” subsection with actuator exposure example?
81-84
: Optional: add logging/privacy knobs.Consider pointing to ways to avoid sensitive data in logs (e.g., reduce log level for Hyperion/Azure/OpenAI clients) and reminding admins not to store API keys in VCS; prefer env vars or externalized config.
I can draft a short “Security & privacy tips” box with env var mappings for the shown properties.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/admin/extension-services.rst
(1 hunks)docs/admin/setup/hyperion.rst
(1 hunks)docs/dev/setup/server.rst
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
docs/dev/setup/server.rst (1)
294-299
: Good cross-reference; fits the structure.The “Production setup” pointer to the admin guide is clear and consistent with the new label. No action needed.
docs/admin/extension-services.rst (1)
35-35
: LGTM — Hyperion added to toctree.Entry renders fine and matches the new page label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f1e1c5a
Checklist
General
Motivation and Context
We want to document how to use
Hyperion
for Artemis administrators.Description
This PR adds setup documentation for Hyperion, detailing how to enable Hyperion and how to configure Spring AI with either OpenAI oder Azure OpenAI
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Summary by CodeRabbit