Skip to content

fix(workshopper): fix docker dns collisions for proxy and database#11

Merged
yinggez merged 1 commit into
mainfrom
workshopper/deploy-fix
Jul 15, 2026
Merged

fix(workshopper): fix docker dns collisions for proxy and database#11
yinggez merged 1 commit into
mainfrom
workshopper/deploy-fix

Conversation

@yinggez

@yinggez yinggez commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Infrastructure & Deployment Fixes
-Fixed NGINX Docker DNS Collision
-Hardened Database Connection
-Documentation Updates (AUTH.md)

Frontend Code Refactoring
-Extracted Shared Utilities (lib/utils.ts & lib/constants.ts)
-Component Modularization:
-Extracted InlineEditText into a dedicated, reusable component to clean up the timetable views.
-Extracted SortableBlockRow to isolate the complex drag-and-drop row rendering logic.
-Cleaned Up Dashboards

@yinggez
yinggez requested review from florivn and zhngharry July 14, 2026 17:52

@florivn florivn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot:
✅ Infrastructure fixes are solid:

  • Docker DNS collision fix is correctly applied across all three locations (nginx.conf routes, compose.prod.yaml, and documented in AUTH.md)
  • The hardened POSTGRES_HOST change prevents future DNS issues

✅ Refactoring is safe & well-executed:

  • Type exports are properly defined: EditTarget and DndActivityBlock exported from WorkshopGeneratedTimetable.tsx (lines 37, 47)
  • All imports are correct and match the exports
  • Zero behavioral changes—pure code organization
  • The extracted components (SortableBlockRow, InlineEditText) have all their handlers wired correctly with proper prop drilling

✅ Centralized utilities work correctly:

  • parseStepDuration() correctly extracts duration from step strings and is used in three places (lines 164, 196 in main component)
  • getSessionStatus() consolidates redundant status logic cleanly
  • Constants (phaseEmojis, phaseRowColors, etc.) are properly accessed in both new component files

@yinggez
yinggez merged commit 9327542 into main Jul 15, 2026
10 checks passed
@yinggez
yinggez deleted the workshopper/deploy-fix branch July 15, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants