feat: setup domain core db communication by vtotalova · Pull Request #16 · ls1intum/memo

vtotalova · 2025-12-10T14:27:16Z

Description

Implemented a complete domain core architecture for database communication following the repository pattern. This establishes a layered approach where only the domain core (repository layer) communicates directly with the database, ensuring proper separation of concerns and maintainability.

Type of Change

Related Issues

Related to feat: setup domain core (db communication) #15

Changes Made

Architecture

Implemented layered architecture: Client Side → Server Actions → Services → Repository Interface → Repository Implementation → Prisma → Database
Created domain entities and input types for all models (User, Competency, LearningResource, CompetencyRelationship, CompetencyResourceLink)
Established repository pattern with interfaces and Prisma implementations
Added service layer for business logic and validation

Database

Updated Prisma schema to fix CompetencyResourceLink inconsistencies
Merged db-setup branch with schema and migration updates

Server

Domain Layer (lib/domain/domain_core.ts): Pure entities and input types for all models
Repository Interfaces (lib/repositories/dc_interface.ts): Contracts for User, Competency, LearningResource, CompetencyRelationship, CompetencyResourceLink repositories
Repository Implementation (lib/repositories/dc_user_repo.ts): Prisma implementations for all repositories (ONLY layer that touches database)
Services (lib/services/):
- user-service.ts - User business logic
- competency-service.ts - Competency business logic
- learning-resource-service.ts - Learning resource business logic with URL uniqueness validation
- competency-relationship-service.ts - Relationship business logic with self-reference validation
- competency-resource-link-service.ts - Resource link business logic
Server Actions (app/actions/):
- users.ts - User CRUD operations
- competencies.ts - Competency CRUD operations
- learning-resources.ts - Learning resource CRUD operations
- competency-relationships.ts - Relationship CRUD operations
- competency-resource-links.ts - Resource link CRUD operations

Documentation

Created DOMAIN_CORE.md with architecture overview, usage examples for Client Side (Server Components and Client Components), API integration guide, and rules

Testing

Test Cases

Existing functionality still works
New functionality works as expected
Edge cases handled appropriately

Manual Testing

Tested in development environment
Verified Prisma Client generation
Verified all layers properly connected
Tested with Prisma Studio for database visualization

Architecture Benefits

SQL Injection Protection: Prisma uses parameterized queries throughout
Type Safety: End-to-end TypeScript type safety from Client Side to database
Testability: Repository interfaces enable easy mocking for unit tests
Separation of Concerns: Clear boundaries between presentation, business logic, and data access
Maintainability: Changes to database layer don't affect business logic or Client Side code

Next Steps

Developers can now:

Use existing Server Actions from Client Side components
Expose services through Next.js API routes for external APIs
Follow the established pattern to add new entities (see existing implementations as reference)

…ure/db-setup

- Add unique constraint on CompetencyRelationship to prevent duplicates - Add database indexes on CompetencyResourceLink foreign keys for performance - Make userId optional in CompetencyResourceLink with SetNull on delete - Add error logging and visibility in migration system - Move database docs to root as DATABASE.md - Sync package-lock.json with package.json (TypeScript 5.9.3) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Co-authored-by: Maximilian Anzinger <44003963+MaximilianAnzinger@users.noreply.github.com>

…munication

github-actions · 2025-12-10T14:32:52Z

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

⚠️ Found console statements - consider removing for production
⚠️ Found 'any' or 'unknown' types - consider using more specific types

Copilot

Pull request overview

This pull request establishes a comprehensive domain core architecture for database communication using Prisma ORM and the repository pattern. The implementation provides a clean, layered approach with proper separation of concerns between the presentation layer, business logic, and data access.

Key changes:

Added Prisma ORM with PostgreSQL support, including schema definition and initial migration
Implemented complete repository pattern with interfaces and Prisma implementations for all domain entities
Created service layer with business logic and validation for Users, Competencies, Learning Resources, and their relationships
Added server actions to expose CRUD operations to the client side
Reorganized utility files and updated component imports
Provided comprehensive documentation (DOMAIN_CORE.md, DATABASE.md)

Reviewed changes

Copilot reviewed 35 out of 38 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
`prisma/schema.prisma`	Database schema defining 5 models with relationships and enums
`prisma/migrations/`	Initial database migration and lock file
`lib/domain/domain_core.ts`	Pure domain entities and input types for all models
`lib/repositories/dc_interface.ts`	Repository interface contracts for data access
`lib/repositories/dc_repo.ts`	Prisma repository implementations (only layer touching database)
`lib/services/*.ts`	Business logic services for each domain entity
`lib/client/prisma.ts`	Prisma client singleton configuration with dev/prod logging
`lib/client/run-migrations.ts`	Runtime migration execution with environment-specific error handling
`lib/client/utils.ts`	Utility functions moved from lib/utils.ts
`app/actions/*.ts`	Server actions exposing CRUD operations for all entities
`instrumentation.ts`	Next.js instrumentation hook for automatic migration execution
`components/ui/*.tsx`	Updated imports to reference new utils location
`DOMAIN_CORE.md`	Architecture documentation with usage examples
`DATABASE.md`	Database setup and migration guide
`package.json`	Added Prisma dependencies and database management scripts
`Dockerfile`	Updated to support Prisma in production with schema and migrations
`docker/staging/docker-compose.yml`	Environment variable adjustments for staging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2025-12-10T15:16:13Z

🔍 Code Quality Report

Ready to merge (after @MaximilianAnzinger's approval)

vtotalova and others added 21 commits November 25, 2025 12:50

add initial db setup

531b385

remove redundant fields in db

6871c30

Merge branch 'main' into feature/db-setup

5e76c47

fix CI and code quality issues

377fab2

remove manually migration, update db setup

f114fa8

Merge branch 'main' into feature/db-setup

f8c2983

check resolved

2b86a16

Merge branch 'feature/db-setup' of github.com:ls1intum/memo into feat…

515d35f

…ure/db-setup

style: fix prettier formatting

5c538fe

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

docs: clarify Prisma Studio usage and DATABASE_URL

0d2d8dd

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

docs: clarify database setup and .env file usage

1b6cb4f

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

remove unnecessary code

626561c

fix npm Ci issues

9b19b68

update doc

1bffd0d

fix CI issued

c7fe36a

fix inconsistency between prisma clinet and db setup file

a7f4c7f

Update prisma/migrations/20251203125815_init/migration.sql

abb04f0

Co-authored-by: Maximilian Anzinger <44003963+MaximilianAnzinger@users.noreply.github.com>

Update prisma/schema.prisma

791f7f3

Co-authored-by: Maximilian Anzinger <44003963+MaximilianAnzinger@users.noreply.github.com>

set up domain core

555c4b7

Merge branch 'feature/db-setup' into feature/setup-domain-core-db-com…

b3f6bc6

…munication

vtotalova added this to the v0.1.0 milestone Dec 10, 2025

vtotalova requested a review from markstockhausen December 10, 2025 14:27

vtotalova self-assigned this Dec 10, 2025

Copilot AI review requested due to automatic review settings December 10, 2025 14:27

vtotalova requested a review from MaximilianAnzinger as a code owner December 10, 2025 14:27

vtotalova added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 10, 2025

vtotalova linked an issue Dec 10, 2025 that may be closed by this pull request

feat: setup domain core (db communication) #15

Closed

vtotalova added the database 🗃️ Database related changes label Dec 10, 2025

Copilot AI reviewed Dec 10, 2025

View reviewed changes

vtotalova added 2 commits December 10, 2025 16:08

fix: export RelationshipType from domain core and update imports

1e768ae

Merge branch 'main' into feature/setup-domain-core-db-communication

1df11b0

github-actions Bot removed docker 🐳 Docker/deployment changes configuration ⚙️ Configuration file changes dependencies 📦 Dependency updates labels Dec 10, 2025

vtotalova added 2 commits December 10, 2025 16:34

move prisma build stage upper

ab4d9f2

Merge branch 'feature/setup-domain-core-db-communication' of github.c…

3e271ef

…om:ls1intum/memo into feature/setup-domain-core-db-communication

github-actions Bot added the docker 🐳 Docker/deployment changes label Dec 10, 2025

markstockhausen requested changes Dec 15, 2025

View reviewed changes

cosmetic minor changes

89eae3f

fix test code issues

c0da752

github-actions Bot added the dependencies 📦 Dependency updates label Dec 15, 2025

vtotalova requested a review from markstockhausen December 15, 2025 21:38

restructure domain core + code issues fixed

e5ad44e

ls1intum deleted a comment from Copilot AI Dec 16, 2025

markstockhausen approved these changes Dec 16, 2025

View reviewed changes

This was referenced Dec 16, 2025

feat: implement mapping actions and enhance flow #21

Merged

feat: update and unify design of landing, about and further subpages #18

Merged

MaximilianAnzinger approved these changes Dec 22, 2025

View reviewed changes

MaximilianAnzinger merged commit 8ff1d3a into main Dec 22, 2025
10 checks passed

MaximilianAnzinger deleted the feature/setup-domain-core-db-communication branch December 22, 2025 13:58

Uh oh!

Conversation

vtotalova commented Dec 10, 2025 • edited by markstockhausen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Related Issues

Changes Made

Architecture

Database

Server

Documentation

Testing

Test Cases

Manual Testing

Architecture Benefits

Next Steps

Uh oh!

github-actions Bot commented Dec 10, 2025

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 10, 2025

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Dec 10, 2025

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 15, 2025

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Dec 15, 2025

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

github-actions Bot commented Dec 16, 2025

🔍 Code Quality Report

📊 Code Statistics

🚨 Potential Issues

Uh oh!

markstockhausen commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

vtotalova commented Dec 10, 2025 •

edited by markstockhausen

Loading

markstockhausen commented Dec 17, 2025 •

edited

Loading