Skip to content

Conversation

Bofan-Zhu
Copy link
Collaborator

@Bofan-Zhu Bofan-Zhu commented Sep 11, 2025

Checklist

General

Motivation and Context

Summary page of application creation form is not showing all values (selected language and date)

Description

  • save date in page3Form when date is updated
  • add preferredLanguage in both state instances

Steps for Testing

Prerequisites:

  1. Login as applicant
  2. Go to Job Overview and click on Apply
  3. Fill out preferred language on page and desired start date on page 3 and check if they are visible in the preview page (Do not leave the application form during those steps)

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Screenshots

Screenshot 2025-09-11 at 18 50 27

@Bofan-Zhu Bofan-Zhu self-assigned this Sep 11, 2025
@Bofan-Zhu Bofan-Zhu requested a review from az108 as a code owner September 11, 2025 16:50
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 11, 2025
Copy link

github-actions bot commented Sep 11, 2025

🚨 OpenAPI Validation Failed 🚨

The OpenAPI specs in openapi.yaml differ from the generated version.
Please update the OpenAPI specs by running:

cd .
./gradlew generateApiDocs -x webapp

Commit and push the updated file.

@Bofan-Zhu Bofan-Zhu added ready for review bug Something isn't working labels Sep 11, 2025
Copy link
Collaborator

@Kiara65 Kiara65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thank you for fixing this!

@Bofan-Zhu Bofan-Zhu added the ready for merge PR is ready to merge label Sep 11, 2025
@az108 az108 merged commit 8476472 into main Sep 13, 2025
18 of 20 checks passed
@az108 az108 deleted the bug/fix-application-summary-page branch September 13, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants