Skip to content

Conversation

Kiara65
Copy link
Collaborator

@Kiara65 Kiara65 commented Sep 11, 2025

Checklist

General

Client

Motivation and Context

After submitting an application, when the screen is too small, the View Application button doesn’t fit the German translation, causing it to become larger than the other buttons, which breaks the overall page design.

Description

  • Removed the icon from the button to accommodate the German translation without having to increase the job card width too much.
  • Increased the job card minimum width from 15 rem to 16.5 rem.
  • Prevented line breaks in the apply buttons.

Steps for Testing

Prerequisites:

  1. Log in to TumApply as an applicant
  2. Navigate to the job overview
  3. Navigate to a job you have applied for
  4. Verify that all buttons remain on a single line and do not wrap, even when the window is small

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Screenshots

Screenshot 2025-09-11 at 23 31 42 Screenshot 2025-09-11 at 23 32 11

@Kiara65 Kiara65 self-assigned this Sep 11, 2025
@Kiara65 Kiara65 requested a review from az108 as a code owner September 11, 2025 21:34
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 11, 2025
@Kiara65 Kiara65 linked an issue Sep 11, 2025 that may be closed by this pull request
Copy link

🚨 OpenAPI Validation Failed 🚨

The OpenAPI specs in openapi.yaml differ from the generated version.
Please update the OpenAPI specs by running:

cd .
./gradlew generateApiDocs -x webapp

Commit and push the updated file.

Copy link
Collaborator

@Bofan-Zhu Bofan-Zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

@Kiara65 Kiara65 added ready for merge PR is ready to merge and removed ready for review labels Sep 12, 2025
@az108 az108 merged commit 6e43d88 into main Sep 13, 2025
24 of 27 checks passed
@az108 az108 deleted the fix-job-card-button branch September 13, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make job Card button smaller
3 participants