Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few llvm19 api change #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a few llvm19 api change #48

wants to merge 1 commit into from

Conversation

707state
Copy link

A little api change and works fine with llvm19.

Copy link
Owner

@lsegal lsegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hard coded paths and this can be merged.

@@ -0,0 +1,92 @@
[
{
"directory": "/home/sgj/codes/fy/my_toy_compiler",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to avoid hard coding paths or this entire file should be removed since it's not related to the changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad. I'll be careful next time.

"file": "parser.cpp"
},
{
"directory": "/home/sgj/codes/fy/my_toy_compiler",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

},
{
"directory": "/home/sgj/codes/fy/my_toy_compiler",
"arguments": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

},
{
"directory": "/home/sgj/codes/fy/my_toy_compiler",
"arguments": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

"file": "corefn.cpp"
},
{
"directory": "/home/sgj/codes/fy/my_toy_compiler",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants