ImageListToImageBatch: make the resize check optional (much faster for long vids) #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeOne
changed the title
BlakeOne
changed the title
BlakeOne
changed the title
ltdrdata
requested changes
Apr 25, 2024
| if len(images) <= 1: | ||
| return (images,) | ||
| elif not resize[0]: |
There was a problem hiding this comment.
This should be not resize instead of not resize[0]
| if len(images) <= 1: | ||
| return (images,) | ||
| elif not resize[0]: | ||
| return (torch.cat(images, dim=0),) |
There was a problem hiding this comment.
It would be advisable to use try-catch in this section to output appropriate error messages in case of exceptions.
There was a problem hiding this comment.
The review was pending due to my mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When operating on a large batch size (eg 500) if the images are all the same size (eg a video), then the node ImageListToImageBatch takes much longer than necessary...
So this PR adds the option to skip the resize check and simply combine all of the images at once, which can be much faster from my testing (10 seconds vs 108 seconds with batch size 550, 512x512 res, tested on Colab T4).