Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing empty mask to SEGS controlnet preprocessors #763

Closed
wants to merge 1 commit into from

Conversation

fAIseh00d
Copy link

@fAIseh00d fAIseh00d commented Sep 30, 2024

Hi!

I encountered an issue when using xinsir's SDXL union controlnet for inpainting with SEGS.

There were two issues:

  1. Wrong inpaint fill color for xinsir union controlnet.
    Fixed here
  2. Not passing cropped mask from SEGS to controlnet preprocessors, resulting in fully black filled controlnet image when using Inpaint Preprocessor Provider (SEGS).
    Fixed in this PR.

Before:
image
After:
image

Be aware that this is a quick fix, and I have not had time to check every possible combination of controlnets and preprocesors.
Also my approach might be suboptimal, and I'm open to improvement suggestions.

Here's the test workflow:
workflow (6).json

@fAIseh00d
Copy link
Author

My bad, turns out that the mask is already passed to preprocessor but only if noise_mask is enabled.

@fAIseh00d fAIseh00d closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant