Reorder client initialization (rebased) #15554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ServerEnv created a player instance before they're fully initialized. This commit moves all initialization steps and callbacks into TOSERVER_CLIENT_READY ^ which includes StageTwoClientInit for player loading or creation
sfan5
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the root issue of:
This reopens #12189 (thanks grorp for pointing it out)
Before
core.get_connected_playersoccasionally returns object references of yet-not-joined players, for example incore.register_globalstepcallbacks. This is a problem becausecore.register_on_joinplayerwas not called yet.Mods rely on joinplayer to initialize their API entries, which causes unpredictable and unreliable code paths.
After
core.get_connected_playersincludes the player reference only after (and including)core.register_on_newplayer, followed bycore.register_on_joinplayer.To do
This PR is Ready for Review.
How to test