Sync ffi branch forward to latest lute. #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title relevant
I'm trying the meme AI terminal, I guess, don't want to commit the markdown context file for it.
Uses a different LUT method to provide a general speed up for encoding operations
The setup options text might be redundant
fifteen billionth iteration of fixing this later, these should be optional
There are print cases not covered by `printBlock` and `printExpr`, so I figure this is useful to have If anything, we can replace `printBlock` with this function and export it as `print` instead, [since`visitStatement` encompasses blocks](https://github.com/luau-lang/lute/blob/primary/lute/std/libs/syntax/visitor.luau#L796), in addition to many statement types --------- Co-authored-by: ariel <[email protected]>
Based on this PR in the Luau repository: luau-lang/luau#1967. I also spent a while trying to get newlines in error messages to play nicely, but we still have some issues that we'll need to address later. Main tension is that `lua_debugtrace` automatically puts a newline at the end of the trace, but a "regular" error on a thread is usually just a string with no newline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@green-real is going to keep working on the FFI branch, so we'd like to keep it in sync with primary to the extent possible.