Add printType function #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidate repeated logic
aatxe
approved these changes
Sep 22, 2025
lute/std/libs/syntax/printer.luau
Outdated
|
|
||
| --- Returns a string representation of an AstExpr | ||
| function printExpr(block: luau.AstExpr): string | ||
| function printNode(node: luau.AstExpr | luau.AstStat | luau.AstType, visit: any): string |
There was a problem hiding this comment.
Can't we do a more precise type for visit here? Looks like it expects a node and a buffer, and returns nothing, so... (node: ..., printer: buffer) -> ()
There was a problem hiding this comment.
Yea, we definitely can. How about:
function printNode<T>(node: T, visit: (node: T, visitor: visitor.Visitor) -> ()): string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
printTypefunction to theprinterAPI. I've been working with thevisitor,parserandprinterAPIs a bunch, and the need for this has come up a few times.This PR also consolidates some repeated logic used across the printing functions