Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test matrix to current versions #41

Closed
wants to merge 1 commit into from

Conversation

kohlerdominik
Copy link
Contributor

Test matrix uses a couple of very old version. I left Laravel 6.x und 7x in it, altough they are out of support.

But you should consider dropping support for PHP < 8.0 and <Laravel 8

@Mulkave
Copy link
Member

Mulkave commented Nov 15, 2022

I was contemplating this myself just now 😄 L9 is a tricky update because it has a breaking change as mentioned in #36 (comment)

As for dropping support for older versions, so far i didn't see a necessity to do that, mainly due to not being blocked from adding features or needing a backward compatibility for them to work. Nevertheless, as soon as it is needed i wouldn't mind dropping them for a new major version bump to indicate so.

Screenshot 2022-11-15 at 2 58 58 PM

@kohlerdominik
Copy link
Contributor Author

For Laravel 6.x and 7.x, one could argue, it doesn't hurt to leave them in just now.

I just wanted to see wether it's an "easy matrix upgrade". But I can't find time right now to fix the issues, so I will close this for now. Sorry :(

@Mulkave
Copy link
Member

Mulkave commented Nov 15, 2022

No worries, thanks for trying! I'll be able to fix this through the week but can't figure out a way to do it without breaking compatibility :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants