Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation and configuration instructions for Rosetta #801

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Add installation and configuration instructions for Rosetta #801

merged 3 commits into from
Sep 27, 2021

Conversation

wout
Copy link
Contributor

@wout wout commented Sep 26, 2021

This fixes #770 and luckyframework/lucky#1284. I've run the setup through a brand new Lucky app and everything went well.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! This looks so nice. Thanks for doing this. I left a few comments and some small typo changes, but overall it looks pretty great!

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Great work on this ❤️

@jwoertink jwoertink merged commit 0e2c4b9 into luckyframework:master Sep 27, 2021
@wout
Copy link
Contributor Author

wout commented Sep 27, 2021

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest new I18n shard
2 participants