Skip to content
This repository was archived by the owner on Feb 25, 2022. It is now read-only.

Remove null elements from LDAP attributes array - #15

Open
tjmcomp wants to merge 12 commits into
luelista:masterfrom
tjmcomp:master
Open

Remove null elements from LDAP attributes array#15
tjmcomp wants to merge 12 commits into
luelista:masterfrom
tjmcomp:master

Conversation

@tjmcomp

@tjmcomp tjmcomp commented Feb 25, 2021

Copy link
Copy Markdown

fixes #14

tjm-sky and others added 2 commits February 25, 2021 19:30
Fix null elements in LDAP attributes array

@luelista luelista left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tjmcomp,
thanks for your tracing that bug and opening this merge request (:
I'd change two things:

  • I don't like the new gitignore, JetBrains recommends otherwise
  • I'd rather create the ldapArray depending on the actual size of the ldapAttributes list.

If you have the time, could you change it? Otherwise, I'll do the change myself when I get around to recompiling the app (need to find the certs...)

Mira

@tjmcomp

tjmcomp commented Mar 3, 2021

Copy link
Copy Markdown
Author

Hi.

I'll revert the gitignore changes to keep it as you had it already.

I did think the size - 2 was a bit simple. :) I'll update today.

@tjmcomp
tjmcomp requested a review from luelista March 3, 2021 12:05
@tjmcomp

tjmcomp commented Mar 28, 2021

Copy link
Copy Markdown
Author

@luelista
I have added a fix for #16 to this pr as well, since I need it for my use case. I may just resurrect my play store account and publish a separate build anyway, but it won't be soon so i'll leave this pr for you to merge when you get a chance.

@luelista

Copy link
Copy Markdown
Owner

Hi @tjmcomp ,
if you want to take over maintaining this app, feel free - I can add a link to your repo in the README if you want. I'm currently not using the app myself, and don't have the spare time to maintain it for fun, so I won't be able to push a new release soon.
Best,
Mira

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync fails with 389-ds LDAP server

3 participants