-
Notifications
You must be signed in to change notification settings - Fork 660
Added android build fix with a minimal CMake stub #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added android build fix with a minimal CMake stub #844
Conversation
|
@erickreutz please review it |
|
waiting for this PR to be merged so that android build error can be resolved @erickreutz Please review and merge |
|
@luancurti can you roll a new release? I'm afraid I'm so rusty with this repo that I'll mess it up. |
@luancurti we are waiting for you 😄 |
|
Still waiting for the new release. |
Waiting soo badly for the new release buddies. |
|
Published |
|
Can someone check if Android build is passing |
|
@protikbiswas100 I am still getting an Android build failure, after upgrading to 1.5.8, cleaning caches, reinstalling etc: |
|
@aravi365 I’m still facing this issue while using "react-native": "0.81.0". FAILURE: Build failed with an exception.
|
|
Raised a pr to fix the build error #845 |
|
@protikbiswas100 Published |
|
@luancurti I have raised a pr #849 please review it and publish a new version to check if android build passes |
What changed
added fabric support for windows, Fabric is the new architecture of react native
Why this change is needed
People using this library should be able to use the new architecture of react native
Testing

Added TurboModule enable flag via react-native.config.js. Wrote a minimal test to assert exported Config object and fallback logic.
Attached image of unit testing