Fix a few SwiftLint warnings

.swiftlint.yml

@@ -2,12 +2,9 @@ disabled_rules:
   - force_cast
   - large_tuple
   - line_length
+  - identifier_name
 
 # paths to ignore during linting
 excluded:
   - Pods
   - Resources
-  - Twig/Libraries
-
-identifier_name:
-  min_length: 1

Pine/AppDelegate.swift

@@ -91,7 +91,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
             DocumentController.shared.openDocument(
               withContentsOf: file,
               display: true,
-              completionHandler: { _,_,_  in
+              completionHandler: { _, _, _  in
                 Utils.getCurrentMainWindowController()?.window?.makeKeyAndOrderFront(nil)
               }
             )

Pine/Controllers/DocumentController.swift

@@ -32,7 +32,7 @@ class DocumentController: NSDocumentController {
         withContentsOf: url,
         display: true,
         completionHandler: completionHandler
-      );
+      )
     }
 
     currentWindowController.syncWindowSidebars()
@@ -62,7 +62,7 @@ class DocumentController: NSDocumentController {
       DocumentController.shared.openDocument(
         withContentsOf: fileAsURL,
         display: true,
-        completionHandler: { _,_,_ in }
+        completionHandler: { _, _, _ in }
       )
 
       return
@@ -83,7 +83,7 @@ class DocumentController: NSDocumentController {
       DocumentController.shared.openDocument(
         withContentsOf: filePathURL,
         display: true,
-        completionHandler: { _,_,_ in }
+        completionHandler: { _, _, _ in }
       )
 
       return

Pine/Controllers/MarkdownViewController.swift

@@ -228,9 +228,9 @@ class MarkdownViewController: NSViewController, NSTextViewDelegate, HighlightDel
   /// Whenever typing attributes in the text view are changed, regenerate the preview
   func textView(
     _ textView: NSTextView,
-    shouldChangeTypingAttributes oldTypingAttributes: [String : Any] = [:],
-    toAttributes newTypingAttributes: [NSAttributedString.Key : Any] = [:]) -> [NSAttributedString.Key : Any]
-  {
+    shouldChangeTypingAttributes oldTypingAttributes: [String: Any] = [:],
+    toAttributes newTypingAttributes: [NSAttributedString.Key: Any] = [:]
+  ) -> [NSAttributedString.Key: Any] {
     self.generatePreview()
     return newTypingAttributes
   }
@@ -334,7 +334,10 @@ extension MarkdownViewController: NSTouchBarDelegate {
     return touchBar
   }
 
-  func touchBar(_ touchBar: NSTouchBar, makeItemForIdentifier identifier: NSTouchBarItem.Identifier) -> NSTouchBarItem? {
+  func touchBar(
+    _ touchBar: NSTouchBar,
+    makeItemForIdentifier identifier: NSTouchBarItem.Identifier
+  ) -> NSTouchBarItem? {
     let item = NSCustomTouchBarItem(identifier: identifier)
 
     switch identifier {

Pine/Controllers/Preferences/PreferencesSidebarViewController.swift

@@ -18,7 +18,7 @@ class PreferencesSidebarViewController: NSViewController {
 
   override func viewDidLoad() {
     super.viewDidLoad()
-    
+
     sidebar.delegate = self
     sidebar.dataSource = self
 

Pine/Controllers/Preferences/PreferencesSplitViewController.swift

@@ -11,7 +11,7 @@ import Cocoa
 class PreferencesSplitViewController: NSSplitViewController {
 
   override func splitView(_ splitView: NSSplitView, effectiveRect proposedEffectiveRect: NSRect, forDrawnRect drawnRect: NSRect, ofDividerAt dividerIndex: Int) -> NSRect {
-    return NSZeroRect
+    return .zero
   }
 
 }

Pine/Controllers/Preferences/PreferencesViewController.swift

@@ -9,7 +9,7 @@
 import Cocoa
 
 class PreferencesViewController: NSViewController {
-  
+
   @IBOutlet weak var scrollView: NSScrollView!
 
   private var stackView: NSStackView!
@@ -65,20 +65,17 @@ class PreferencesViewController: NSViewController {
     switch category {
     case .ui:
       views = uiStackView.getViews()
-      break
     case .markdown:
       views = markdownStackView.getViews()
-      break
     case .document:
       views = documentStackView.getViews()
-      break
     }
 
     for (index, view) in views.enumerated() {
       stackView.addArrangedSubview(view)
 
       // Add a seperator underneath all views except last
-      if (index != views.count - 1) {
+      if index != views.count - 1 {
         let hr = NSBox()
         hr.boxType = .separator
 
@@ -104,5 +101,5 @@ class PreferencesViewController: NSViewController {
 
     NSLayoutConstraint.activate(stackViewConstraints)
   }
-  
+
 }

Pine/Controllers/Preferences/PreferencesWindowController.swift

@@ -19,4 +19,3 @@ class PreferencesWindowController: NSWindowController, NSWindowDelegate {
   }
 
 }
-

Pine/Controllers/SidebarViewController.swift

@@ -246,7 +246,7 @@ extension SidebarViewController: NSOutlineViewDataSource {
 
   /// The NSTableRowView instance to be used
   func outlineView(_ outlineView: NSOutlineView, rowViewForItem item: Any) -> NSTableRowView? {
-    return SidebarTableRowView(frame: NSZeroRect)
+    return SidebarTableRowView(frame: .zero)
   }
 
 }
@@ -290,4 +290,3 @@ extension SidebarViewController: NSMenuDelegate {
   }
 
 }
-

Pine/Extensions/NSTextView.swift

@@ -93,8 +93,8 @@ extension NSTextView {
     atLineStart: Bool = false,
     newLineIfSelected: Bool = false
   ) {
-    var leftString: String? = nil
-    var rightString: String? = nil
+    var leftString: String?
+    var rightString: String?
 
     if let l = left {
       leftString = String(l)
@@ -167,5 +167,5 @@ extension NSTextView {
 
     self.replace(right: match)
   }
-  
+
 }

Pine/Extensions/NSView.swift

@@ -14,5 +14,5 @@ extension NSView {
     wantsLayer = true
     layer?.backgroundColor = color.cgColor
   }
-  
+
 }

Pine/Views/Preferences/PreferencesStackView.swift

@@ -24,7 +24,7 @@ class PreferencesStackView: NSStackView {
   private var prefView: NSStackView!
 
   init(name: String) {
-    super.init(frame: NSZeroRect)
+    super.init(frame: .zero)
 
     self.name = name
     self.hasSection = false

Pine/Views/Preferences/UIStackView.swift

@@ -43,7 +43,7 @@ class UIStackView: NSStackView, PreferenceStackView, NSFontChanging {
 
     view.addPreferences([
       syntaxDropdown,
-      revealThemesButton,
+      revealThemesButton
     ])
 
     view.addBooleanArea(

Pine/Views/SidebarTableRowView.swift

@@ -12,12 +12,12 @@ class SidebarTableRowView: NSTableRowView {
 
   // Draw a custom selection
   override func drawSelection(in dirtyRect: NSRect) {
-    let selectionRect = NSInsetRect(self.bounds, 0, 0)
+    let selectionRect = self.bounds
 
     NSColor.selectedControlColor.setStroke()
     NSColor.selectedControlColor.setFill()
 
-    let selectionPath = NSBezierPath.init(roundedRect: selectionRect, xRadius: 0, yRadius: 0)
+    let selectionPath = NSBezierPath(roundedRect: selectionRect, xRadius: 0, yRadius: 0)
     selectionPath.fill()
     selectionPath.stroke()
   }

PineTests/TextViewTests.swift

@@ -48,7 +48,7 @@ class TextViewTests: XCTestCase {
     textView.replace(left: "```\n", right: "\n```", newLineIfSelected: true)
 
     let newContents = textView.textStorage?.string
-    
+
     XCTAssert(newContents == "\n```\n\n```\n")
   }