Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process polyfill for mobile compatibility #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gvivster
Copy link

Fixes #10 Making it function on a mobile device
(at least for Android, not tested on iOS - if someone with an iOS device could let me know if it works, I'd appreciate it.)

@lukasbach

Problem

Plugin wasn't working on mobile - it would fail to activate with this error:
image
(It WOULD work on the emulated version on desktop, which made it more confusing.)
Apparently it couldn't find the process object.
Added a process polyfill to fix this.

Changes

  • Created process-polyfill.ts to provide the basic environment stuff React needs
  • Added import for the polyfill in main.ts

Testing

Got it working on my Android Note S9! The plugin now:

  • Activates properly
  • Shows up in the menu
  • Lets me reorder files just like on desktop

It's finally perfect for my Android needs! (happy dance) Let me know if you need me to test anything else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making it function on a mobile device
1 participant