Add a chemiscope example. #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think having the code testable is worth a dev dependcy |
|
Added the dependency, tests should pass. |
lukasturcani
approved these changes
Oct 14, 2024
docs/source/basic_examples.rst
Outdated
| Requirements | ||
| ------------ | ||
|
|
||
| :mod:`chemiscope` makes it easy for you to write a `.json` or `.json.gz` |
There was a problem hiding this comment.
should be dboule backtics for .json and .json.gz
docs/source/basic_examples.rst
Outdated
|
|
||
| __ https://cgmodels.readthedocs.io/en/latest/cg_model_jul2023_2p3_ton.html | ||
|
|
||
| Either way, you need to write a `.json` or `.json.gz` file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding a small example to raise awareness of the utility of the tool. I am happy to change the scope as necessary.
Note that I have not made the python code testable to avoid the need for a new dev dependancy,