Enhanced JAX compatibility #1490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZongrenZou Any suggestions? |
|
You can split this PR into two PRs, one about ics/bcs, another one about Orbax |
tttc3
force-pushed
the
jax-compatibility
branch
from
f4fdc0c
to
c192182
Compare
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides JAX compatibility with most ics and bcs. In addition, it provides checkpointing via Orbax.
To avoid requiring Orbax as a package wide dependency it is conditionally imported. While this provides the desired result, it is not PEP8 compliant; any better suggestions would be greatly appreciated.