Implement Arrayable and SerializesCastableAttributes

lunarphp · Sep 15, 2023 · 25a3f06 · 25a3f06
1 parent 36c5672
commit 25a3f06
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 13 deletions.
diff --git a/packages/core/src/Base/Casts/Price.php b/packages/core/src/Base/Casts/Price.php
@@ -3,11 +3,12 @@
 namespace Lunar\Base\Casts;
 
 use Illuminate\Contracts\Database\Eloquent\CastsAttributes;
+use Illuminate\Contracts\Database\Eloquent\SerializesCastableAttributes;
 use Illuminate\Support\Facades\Validator;
 use Lunar\DataTypes\Price as PriceDataType;
 use Lunar\Models\Currency;
 
-class Price implements CastsAttributes
+class Price implements CastsAttributes, SerializesCastableAttributes
 {
     /**
      * Cast the given value.
@@ -55,4 +56,17 @@ public function set($model, $key, $value, $attributes)
             $key => $value,
         ];
     }
+
+    /**
+     * Get the serialized representation of the value.
+     *
+     * @param  \Illuminate\Database\Eloquent\Model  $model
+     * @param  string  $key
+     * @param  \Illuminate\Support\Collection  $value
+     * @param  array<string, mixed>  $attributes
+     */
+    public function serialize($model, $key, $value, $attributes)
+    {
+        return $value->toArray();
+    }
 }
diff --git a/packages/core/src/Base/Casts/TaxBreakdown.php b/packages/core/src/Base/Casts/TaxBreakdown.php
@@ -66,16 +66,7 @@ public function set($model, $key, $value, $attributes)
     public function serialize($model, $key, $value, $attributes)
     {
         return $value->map(function ($rate) {
-            $rate = is_array($rate) ? (object) $rate : $rate;
-
-            if ($rate->total instanceof Price) {
-                $rate->total = (object) [
-                    'value' => $rate->total->value,
-                    'formatted' => $rate->total->formatted,
-                    'currency' => $rate->total->currency->toArray(),
-                ];
-            }
-
+            $rate->total = $rate->total->toArray();
             return $rate;
         })->toJson();
     }

diff --git a/packages/core/src/DataTypes/Price.php b/packages/core/src/DataTypes/Price.php
@@ -2,11 +2,12 @@
 
 namespace Lunar\DataTypes;
 
+use Illuminate\Contracts\Support\Arrayable;
 use Lunar\Exceptions\InvalidDataTypeValueException;
 use Lunar\Models\Currency;
 use Lunar\Pricing\DefaultPriceFormatter;
 
-class Price
+class Price implements Arrayable
 {
     /**
      * Initialise the Price datatype.
@@ -100,4 +101,19 @@ protected function formatValue(int|float $value, ...$arguments): mixed
     {
         return $this->formatter()->formatValue($value, ...$arguments);
     }
+
+    /**
+     * Get the instance as an array.
+     *
+     * @return array<TKey, TValue>
+     */
+    public function toArray()
+    {
+        return [
+            'value' => $this->value,
+            'decimal' => $this->decimal,
+            'formatted' => $this->formatted,
+            'currency' => $this->currency->code,
+        ];
+    }
 }
diff --git a/packages/core/tests/Unit/Models/OrderTest.php b/packages/core/tests/Unit/Models/OrderTest.php
@@ -94,7 +94,7 @@ public function can_serialize_an_order()
 
         $data = $order->toArray();
 
-        $this->assertIsInt($order->total);
+        $this->assertIsInt($data['total']['value']);
     }
 
     /** @test */