Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpunit coverage path and testsuites #1260

Merged

Conversation

netzknecht
Copy link
Contributor

@netzknecht netzknecht commented Sep 21, 2023

  1. Fix the path defined for code coverage inside the phpunit.xml file of the monorepo lunarphp/lunar.
  2. Add all testsuites of the lunarphp/core repo into its phpunit.xml file.
  3. Collect all testsuites into the phpunit.xml file from the monorepo lunarphp/lunar.

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 9:06am

@alecritson
Copy link
Collaborator

Thanks @netzknecht Can you just give a brief overview of what you're trying to solve here? I only ask because I noticed some files you're referencing don't contain tests, such as stubs.

@netzknecht
Copy link
Contributor Author

You are right @alecritson - rework is done.

@netzknecht
Copy link
Contributor Author

Thanks @netzknecht Can you just give a brief overview of what you're trying to solve here?

I've build me a local test env with docker and change this to be able to run the testsuites separate, like defined inside the separate packages.

@alecritson alecritson merged commit f6aba42 into lunarphp:0.5 Sep 22, 2023
@netzknecht netzknecht deleted the fix-phpunit-coverage-path-and-testsuites branch September 25, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants