Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the user is null when logging out #1269

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Check if the user is null when logging out #1269

merged 1 commit into from
Sep 28, 2023

Conversation

dewebdesigns
Copy link
Contributor

Laravel Dusk passes null to the $event->user, so it throws an error. Adding a simple null check fixes this.

@vercel
Copy link

vercel bot commented Sep 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2023 7:34am

@alecritson
Copy link
Collaborator

Thanks @dewebdesigns I feel like this would benefit from being in 0.6, can you change the target branch please :)

@dewebdesigns dewebdesigns changed the base branch from main to 0.6 September 27, 2023 13:33
@dewebdesigns
Copy link
Contributor Author

@alecritson I have updated the target branch to 0.6. Thank you!

@alecritson alecritson merged commit 1f25964 into lunarphp:0.6 Sep 28, 2023
@dewebdesigns dewebdesigns deleted the bugfix/add-null-check-for-logout branch October 19, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecritson alecritson alecritson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dewebdesigns @alecritson